[webkit-changes] [WebKit/WebKit] 3745ca: [Cocoa] Adjust page color sampling heuristic to no...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3745ca7490caae96f45a148b838b988134608f91
      https://github.com/WebKit/WebKit/commit/3745ca7490caae96f45a148b838b988134608f91
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2025-02-18 (Tue, 18 Feb 2025)

  Changed paths:
    M LayoutTests/fast/page-color-sampling/basic-fixed-container-edge-sampling.html
    M Source/WebCore/page/PageColorSampler.cpp
    M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
    M Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h

  Log Message:
  -----------
  [Cocoa] Adjust page color sampling heuristic to not fall back on extended page background color
https://bugs.webkit.org/show_bug.cgi?id=287883

Reviewed by Abrar Rahman Protyasha.

Make small adjustments to the heuristic added in 290447 at main:

-   Remove the "extended page background color" fallback.
-   Instead, add a separate method that returns `_WKRectEdge`, indicating which edges of the
    viewport are adjacent to fixed-position containers.

* LayoutTests/fast/page-color-sampling/basic-fixed-container-edge-sampling.html:

Rebaseline a layout test.

* Source/WebCore/page/PageColorSampler.cpp:
(WebCore::PageColorSampler::predominantColor):
* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _fixedContainerEdges]):
(-[WKWebView _updateFixedContainerEdges:]):
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:

Canonical link: https://commits.webkit.org/290570@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications