[webkit-changes] [WebKit/WebKit] cb86c6: [UnifiedPDF] [iOS] Zoom locked after using per sit...

[Abrar Rahman Protyasha]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cb86c682ac0167a7161e57f5742490f9650e3ec3
      https://github.com/WebKit/WebKit/commit/cb86c682ac0167a7161e57f5742490f9650e3ec3
  Author: Abrar Rahman Protyasha <a_protyasha at apple.com>
  Date:   2025-02-18 (Tue, 18 Feb 2025)

  Changed paths:
    M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Source/WebKit/UIProcess/WebPageProxy.h
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/UnifiedPDFTests.mm

  Log Message:
  -----------
  [UnifiedPDF] [iOS] Zoom locked after using per site zoom
https://bugs.webkit.org/show_bug.cgi?id=287857
rdar://144613344

Reviewed by Wenson Hsieh.

Currently, Safari's page format menu and the pinch gesture zooming do
not play hand in hand, manifesting in unexpected symptoms such as the
bug title.

This patch serves a harder whammy placed on our ability to respect page
scale adjustments driven through Safari's page format menu. We do so by
dropping scale updates on the floor when we detect a main frame plugin
which does not scale factor updates. We also take care to restore the
client-driven layout size scale factor to 1 in place of some other
default. (again, to prevent the "locking" seen above)

API test: UnifiedPDF.ShouldNotRespectSetViewScale

* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _setViewScale:]):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::mainFramePluginOverridesViewScale const):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/UnifiedPDFTests.mm:
(TestWebKitAPI::UNIFIED_PDF_TEST):

Canonical link: https://commits.webkit.org/290565@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications