[webkit-changes] [WebKit/WebKit] 4e04f8: REGRESSION(290502 at main): Triggers assertion in Tes...

[aestes]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4e04f80f4db53ce6deef48ccf9ab09ec16dc2564
      https://github.com/WebKit/WebKit/commit/4e04f80f4db53ce6deef48ccf9ab09ec16dc2564
  Author: Andy Estes <aestes at apple.com>
  Date:   2025-02-18 (Tue, 18 Feb 2025)

  Changed paths:
    M Source/WebKit/UIProcess/mac/WebViewImpl.h
    M Source/WebKit/UIProcess/mac/WebViewImpl.mm

  Log Message:
  -----------
  REGRESSION(290502 at main): Triggers assertion in TestWebKitAPI.WKWebViewCandidateTests.ShouldNotRequestCandidatesInPasswordField
https://bugs.webkit.org/show_bug.cgi?id=287863
rdar://145062868

Reviewed by Wenson Hsieh.

Closing TestWKWebView's host window at the end of each API test exposed an assertion failure when
the window is first responder when closed. Resolved by observing NSWindowWillCloseNotification and
calling WebViewImpl::resetSecureInputState() when the notification is dispatched.

Covered by existing API tests.

* Source/WebKit/UIProcess/mac/WebViewImpl.h:
* Source/WebKit/UIProcess/mac/WebViewImpl.mm:
(-[WKWindowVisibilityObserver startObserving:]):
(-[WKWindowVisibilityObserver _windowWillClose:]):
(WebKit::WebViewImpl::windowWillClose):

Canonical link: https://commits.webkit.org/290548@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications