[webkit-changes] [WebKit/WebKit] 3b9317: Fix crash in VideoPresentationInterfaceIOS::ensure...

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3b9317ac0643e0a9a2e11771100455dec32ba8fc
      https://github.com/WebKit/WebKit/commit/3b9317ac0643e0a9a2e11771100455dec32ba8fc
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2025-02-18 (Tue, 18 Feb 2025)

  Changed paths:
    M Source/WebCore/platform/ios/VideoPresentationInterfaceIOS.mm

  Log Message:
  -----------
  Fix crash in VideoPresentationInterfaceIOS::ensurePipPlacardIsShowing
https://bugs.webkit.org/show_bug.cgi?id=287804
rdar://143843623

Reviewed by Eric Carlson.

289188 at main added some code that creates an array of constraints.
If the parentView is null, though, we crash with NSInvalidArgumentException.
This adds a check.  If there is nothing to add constraints to, don't crash.

* Source/WebCore/platform/ios/VideoPresentationInterfaceIOS.mm:
(WebCore::VideoPresentationInterfaceIOS::ensurePipPlacardIsShowing):

Canonical link: https://commits.webkit.org/290531@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications