[webkit-changes] [WebKit/WebKit] 5da6fa: Remove SPI that returns a DownloadProxy wrapper sy...

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5da6fad1731a883b7509969a04421c52750ffa41
      https://github.com/WebKit/WebKit/commit/5da6fad1731a883b7509969a04421c52750ffa41
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2025-02-17 (Mon, 17 Feb 2025)

  Changed paths:
    M Source/WebKit/UIProcess/API/C/WKContext.cpp
    M Source/WebKit/UIProcess/API/C/WKContext.h
    M Source/WebKit/UIProcess/API/Cocoa/WKProcessPool.mm
    M Source/WebKit/UIProcess/API/Cocoa/WKProcessPoolPrivate.h
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/Download.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm

  Log Message:
  -----------
  Remove SPI that returns a DownloadProxy wrapper synchronously
https://bugs.webkit.org/show_bug.cgi?id=287822
rdar://145007201

Reviewed by Per Arne Vollan.

There are 4 ways to make a download:
1. WKWebView.startDownloadUsingRequest
2. WKWebView.resumeDownloadFromResumeData
3. WKNavigationActionPolicyDownload
4. WKNavigationResponsePolicyDownload
They all give the API surface the download object asynchronously.
We have some unused SPI that returns the download synchronously.
Let's get rid of them.  This will allow me to do some needed cleanup.

* Source/WebKit/UIProcess/API/C/WKContext.cpp:
(WKContextDownloadURLRequest): Deleted.
(WKContextResumeDownload): Deleted.
* Source/WebKit/UIProcess/API/C/WKContext.h:
* Source/WebKit/UIProcess/API/Cocoa/WKProcessPool.mm:
(-[WKProcessPool _downloadURLRequest:websiteDataStore:originatingWebView:]): Deleted.
(-[WKProcessPool _resumeDownloadFromData:websiteDataStore:path:originatingWebView:]): Deleted.
* Source/WebKit/UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
(-[DownloadObserver observeValueForKeyPath:ofObject:change:context:]):
(-[DownloadCancelingDelegate download:decideDestinationUsingResponse:suggestedFilename:completionHandler:]):
(-[AuthenticationChallengeHandlingDelegate download:decideDestinationUsingResponse:suggestedFilename:completionHandler:]):
(-[AuthenticationChallengeHandlingDelegate download:didReceiveAuthenticationChallenge:completionHandler:]):
(-[AuthenticationChallengeHandlingDelegate downloadDidFinish:]):
(TEST(WKDownload, ResumedDownloadCanHandleAuthenticationChallenge)):
(TEST(WKDownload, Resume)):
(-[DownloadCancelingDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]): Deleted.
(-[DownloadCancelingDelegate _download:didReceiveData:]): Deleted.
(-[DownloadCancelingDelegate _downloadDidCancel:]): Deleted.
(-[AuthenticationChallengeHandlingDelegate _download:didReceiveAuthenticationChallenge:completionHandler:]): Deleted.
(-[AuthenticationChallengeHandlingDelegate _downloadDidFinish:]): Deleted.
(TEST(_WKDownload, ResumedDownloadCanHandleAuthenticationChallenge)): Deleted.
(TEST(_WKDownload, Resume)): Deleted.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
(-[DownloadProgressTestRunner startDownload:expectedLength:]):
(TEST(DownloadProgress, StartDownloadInProcessPool)): Deleted.

Canonical link: https://commits.webkit.org/290510@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications