[webkit-changes] [WebKit/WebKit] 16ef01: [WebDriver] Add flag to allow replacing a stale se...

[Lauro Moura]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 16ef019e907d305c91ca4e90b22273380fd5482a
      https://github.com/WebKit/WebKit/commit/16ef019e907d305c91ca4e90b22273380fd5482a
  Author: Lauro Moura <lmoura at igalia.com>
  Date:   2025-02-17 (Mon, 17 Feb 2025)

  Changed paths:
    M Source/WebDriver/WebDriverService.cpp
    M Source/WebDriver/WebDriverService.h

  Log Message:
  -----------
  [WebDriver] Add flag to allow replacing a stale session
https://bugs.webkit.org/show_bug.cgi?id=287540

Reviewed by Carlos Garcia Campos.

Ideally, the client code should take care of properly cleaning up
existing sessions. But if it happens to fail to do so, the driver might
get stuck with a stale session, preventing the creation of new ones,
given our current policy of having at most one session active.

This commit adds an option to avoid this by with a new flag that
destroys the currently active session when requested to create new ones.

Also, drive-by safer-cpp fix on nearby code, replacing printf with
SAFE_PRINT.

* Source/WebDriver/WebDriverService.cpp:
(WebDriver::printUsageStatement):
(WebDriver::WebDriverService::run):
(WebDriver::WebDriverService::newSession):
(WebDriver::WebDriverService::deleteSession):
* Source/WebDriver/WebDriverService.h:

Canonical link: https://commits.webkit.org/290489@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications