[webkit-changes] [WebKit/WebKit] fd292e: Fix some more fullscreen crashes after 290289 at main

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fd292e91ff830956c59a29760830e2868d016ade
      https://github.com/WebKit/WebKit/commit/fd292e91ff830956c59a29760830e2868d016ade
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2025-02-15 (Sat, 15 Feb 2025)

  Changed paths:
    M Source/WebCore/dom/DocumentFullscreen.cpp
    M Source/WebCore/dom/FullscreenManager.cpp

  Log Message:
  -----------
  Fix some more fullscreen crashes after 290289 at main
https://bugs.webkit.org/show_bug.cgi?id=287766
rdar://144931577

Unreviewed.

290289 at main introduced a few cases where we call a CompletionHandler
without checking if it is null.  There are a few places where we pass in a null
CompletionHandler, though.  This makes them do nothing instead of crash,
which is what we did before 290289 at main.

* Source/WebCore/dom/DocumentFullscreen.cpp:
(WebCore::DocumentFullscreen::webkitExitFullscreen):
* Source/WebCore/dom/FullscreenManager.cpp:
(WebCore::FullscreenManager::exitRemovedFullscreenElement):

Canonical link: https://commits.webkit.org/290455@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications