[webkit-changes] [WebKit/WebKit] 1ea2f5: Crash in WebExtensionStorageSQLiteStore::setKeyedD...

[Timothy Hatcher]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1ea2f52e216a188dcf7025d9ab588059d840d97d
      https://github.com/WebKit/WebKit/commit/1ea2f52e216a188dcf7025d9ab588059d840d97d
  Author: Timothy Hatcher <timothy at apple.com>
  Date:   2025-02-15 (Sat, 15 Feb 2025)

  Changed paths:
    M Source/WebKit/Shared/Extensions/WebExtensionSQLiteStore.cpp
    M Source/WebKit/UIProcess/Extensions/WebExtensionStorageSQLiteStore.cpp

  Log Message:
  -----------
  Crash in WebExtensionStorageSQLiteStore::setKeyedData.
https://webkit.org/b/287727
rdar://133560805

Reviewed by Brian Weinstein.

Perform thread-safe copies of values sent to the extension storage queue and before
sending them back to the main queue.

* Source/WebKit/Shared/Extensions/WebExtensionSQLiteStore.cpp:
(WebKit::WebExtensionSQLiteStore::deleteDatabase):
(WebKit::WebExtensionSQLiteStore::createSavepoint):
(WebKit::WebExtensionSQLiteStore::commitSavepoint):
(WebKit::WebExtensionSQLiteStore::rollbackToSavepoint):
* Source/WebKit/UIProcess/Extensions/WebExtensionStorageSQLiteStore.cpp:
(WebKit::WebExtensionStorageSQLiteStore::getAllKeys):
(WebKit::WebExtensionStorageSQLiteStore::getValuesForKeys):
(WebKit::WebExtensionStorageSQLiteStore::getStorageSizeForKeys):
(WebKit::WebExtensionStorageSQLiteStore::getStorageSizeForAllKeys):
(WebKit::WebExtensionStorageSQLiteStore::setKeyedData):
(WebKit::WebExtensionStorageSQLiteStore::deleteValuesForKeys):

Canonical link: https://commits.webkit.org/290441@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications