[webkit-changes] [WebKit/WebKit] 483990: [UnifiedPDF] [iOS] Tapping on anchor link does not...

[Abrar Rahman Protyasha]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 483990ae5b77d63decdc78be91d75396a4473f6a
      https://github.com/WebKit/WebKit/commit/483990ae5b77d63decdc78be91d75396a4473f6a
  Author: Abrar Rahman Protyasha <a_protyasha at apple.com>
  Date:   2025-02-13 (Thu, 13 Feb 2025)

  Changed paths:
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm
    M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/UnifiedPDFTests.mm
    A Tools/TestWebKitAPI/Tests/WebKitCocoa/anchorLink.pdf

  Log Message:
  -----------
  [UnifiedPDF] [iOS] Tapping on anchor link does not clear existing selection
https://bugs.webkit.org/show_bug.cgi?id=287597
rdar://144742522

Reviewed by Wenson Hsieh.

This patch aligns us better with text selection behavior in web content
for touch taps on iOS, by dismissing an existing selection if we tap on
an annotation.

* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::handleSyntheticClick):
* Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/UnifiedPDFTests.mm:
(TestWebKitAPI::UNIFIED_PDF_TEST):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/anchorLink.pdf: Added.

Canonical link: https://commits.webkit.org/290390@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications