[webkit-changes] [WebKit/WebKit] d8e90a: [WebGPUSwift] make Swift.String the default String

nmahendru noreply at github.com
Thu Feb 13 10:00:20 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d8e90aae1092180f5e2ac7b7eb2cfc86071dc5b2
      https://github.com/WebKit/WebKit/commit/d8e90aae1092180f5e2ac7b7eb2cfc86071dc5b2
  Author: Nitin Mahendru <nitinmahendru at apple.com>
  Date:   2025-02-13 (Thu, 13 Feb 2025)

  Changed paths:
    M Source/WTF/wtf/text/WTFString.h
    M Source/WebGPU/WebGPU/CommandEncoder.swift

  Log Message:
  -----------
  [WebGPUSwift] make Swift.String the default String
rdar://144586613
https://bugs.webkit.org/show_bug.cgi?id=287462

Reviewed by Tadeu Zagallo.

In Forward.h, we have a declaration `using WTF::String` which overrides
Swift.String type. Without this change whenever you say String, it means WTF.String
which is just an unecessary brain exercise :)
The typealias declaration added should be available to all swift files
in WebGPU project and String should mean Swift.String
from now on.
WTF.String is now WTFString.
Also, now, we don't need the ifdef in WTFString.h that hides the overloaded operator""().

* Source/WTF/wtf/text/WTFString.h:
* Source/WebGPU/WebGPU/CommandEncoder.h:
(WebGPU::CommandEncoder::createCommandBuffer):
* Source/WebGPU/WebGPU/CommandEncoder.swift:
(WebGPU.validateFinishError):
(WebGPU.finish(_:)):
(WebGPU.runClearEncoder(_:depthStencilAttachmentToClear:depthAttachmentToClear:stencilAttachmentToClear:depthClearValue:stencilClearValue:existingEncoder:)):
(WebGPU.errorValidatingCopyBufferToBuffer(_:sourceOffset:destination:destinationOffset:size:)):
(WebGPU.errorValidatingCopyTextureToTexture(_:destination:copySize:)):
(WebGPU.errorValidatingCopyTextureToBuffer(_:destination:copySize:)):
(WebGPU.errorValidatingImageCopyBuffer(_:)):
(WebGPU.errorValidatingCopyBufferToTexture(_:destination:copySize:)):
(WebGPU.errorValidatingRenderPassDescriptor(_:)):
(WebGPU.errorValidatingTimestampWrites(_:)):
(WebGPU.errorValidatingComputePassDescriptor(_:)):
(WebGPU.beginComputePass(_:)):

Canonical link: https://commits.webkit.org/290344@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list