[webkit-changes] [WebKit/WebKit] 7bfcab: AX: use constants for accessibility APIs rather th...

[Dominic Mazzoni]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7bfcab80374a45e733ed06eef88d59716d451683
      https://github.com/WebKit/WebKit/commit/7bfcab80374a45e733ed06eef88d59716d451683
  Author: Dominic Mazzoni <dm_mazzoni at apple.com>
  Date:   2025-02-13 (Thu, 13 Feb 2025)

  Changed paths:
    M Source/WebCore/accessibility/cocoa/AXCoreObjectCocoa.mm
    M Source/WebCore/accessibility/mac/AXObjectCacheMac.mm
    M Source/WebCore/accessibility/mac/AccessibilityObjectMac.mm
    M Source/WebCore/accessibility/mac/CocoaAccessibilityConstants.h
    M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm
    M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm

  Log Message:
  -----------
  AX: use constants for accessibility APIs rather than hardcoding strings into the code
https://bugs.webkit.org/show_bug.cgi?id=287486
rdar://144621410

Reviewed by Tyler Wilcock.

Replace hardcoded strings of the form @"AX..." with constants defined in CocoaAccessibilityConstants.h

* Source/WebCore/accessibility/cocoa/AXCoreObjectCocoa.mm:
(WebCore::attributedStringSetFont):
(WebCore::AXCoreObject::createAttributedString const):
* Source/WebCore/accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::postPlatformNotification):
(WebCore::AXObjectCache::platformHandleFocusedUIElementChanged):
* Source/WebCore/accessibility/mac/AccessibilityObjectMac.mm:
(WebCore::AccessibilityObject::subrolePlatformString const):
(WebCore::AccessibilityObject::rolePlatformDescription const):
(WebCore::Accessibility::createPlatformRoleMap):
* Source/WebCore/accessibility/mac/CocoaAccessibilityConstants.h:
* Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
(-[WebAccessibilityObjectWrapperBase accessibilityPostedNotification:userInfo:]):
(accessibilitySearchCriteriaForSearchPredicate):
* Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(misspellingSearchCriteriaForParameterizedAttribute):
(-[WebAccessibilityObjectWrapper _additionalAccessibilityAttributeNames:]):
(-[WebAccessibilityObjectWrapper ALLOW_DEPRECATED_IMPLEMENTATIONS_END]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
(attributeValueForTesting):
(parameterizedAttributeValueForTesting):
(-[WebAccessibilityObjectWrapper _accessibilityHitTestResolvingRemoteFrame:callback:]):
(-[WebAccessibilityObjectWrapper accessibilityPerformAction:]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):

Canonical link: https://commits.webkit.org/290342@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications