[webkit-changes] [WebKit/WebKit] 494254: [macOS] Add support for an internal setting to aut...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 49425419f144df857cd829eec5c50950a72ee368
      https://github.com/WebKit/WebKit/commit/49425419f144df857cd829eec5c50950a72ee368
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2025-02-12 (Wed, 12 Feb 2025)

  Changed paths:
    M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
    M Source/WebKit/Platform/spi/mac/AppKitSPI.h
    M Source/WebKit/Shared/Cocoa/WebPreferencesDefaultValuesCocoa.mm
    M Source/WebKit/Shared/WebPreferencesDefaultValues.h
    M Source/WebKit/SourcesCocoa.txt
    M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
    A Source/WebKit/UIProcess/Cocoa/AppKitSoftLink.h
    A Source/WebKit/UIProcess/Cocoa/AppKitSoftLink.mm
    R Source/WebKit/UIProcess/ios/AppKitSoftLink.h
    R Source/WebKit/UIProcess/ios/AppKitSoftLink.mm
    M Source/WebKit/UIProcess/mac/WebViewImpl.h
    M Source/WebKit/UIProcess/mac/WebViewImpl.mm
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj

  Log Message:
  -----------
  [macOS] Add support for an internal setting to automatically fill the content inset area with a background color
https://bugs.webkit.org/show_bug.cgi?id=287599
rdar://144744355

Reviewed by Abrar Rahman Protyasha.

Add support for a new compile-time flag, `ENABLE(CONTENT_INSET_BACKGROUND_FILL)`, as well as a new
runtime setting (`contentInsetBackgroundFillEnabled`) to guard this behavior. See below for more
details.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebKit/Platform/spi/mac/AppKitSPI.h:
* Source/WebKit/Shared/Cocoa/WebPreferencesDefaultValuesCocoa.mm:
* Source/WebKit/Shared/WebPreferencesDefaultValues.h:
* Source/WebKit/SourcesCocoa.txt:
* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _recalculateViewportSizesWithMinimumViewportInset:maximumViewportInset:throwOnInvalidInput:]):
* Source/WebKit/UIProcess/Cocoa/AppKitSoftLink.h: Renamed from Source/WebKit/UIProcess/ios/AppKitSoftLink.h.
* Source/WebKit/UIProcess/Cocoa/AppKitSoftLink.mm: Renamed from Source/WebKit/UIProcess/ios/AppKitSoftLink.mm.

Move this file from `UIProcess/ios` to `UIProcess/Cocoa`, so it can be used on both Catalyst and
macOS proper.

* Source/WebKit/UIProcess/mac/WebViewImpl.h:

Add the new member variable, and also give `_textInputNotifications` an `m`-prefix since this is a
C++ class.

* Source/WebKit/UIProcess/mac/WebViewImpl.mm:
(WebKit::m_flagsChangedEventMonitorTrackingArea):
(WebKit::WebViewImpl::setAcceleratedCompositingRootLayer):
(WebKit::WebViewImpl::updateCursorAccessoryPlacement):
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/290326@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications