[webkit-changes] [WebKit/WebKit] 17928a: Add hasDataList() method to HTMLInputElement.

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 17928aafa0fbd3a0ce788541622916f2e1b6f988
      https://github.com/WebKit/WebKit/commit/17928aafa0fbd3a0ce788541622916f2e1b6f988
  Author: Alice Boxhall <aboxhall at chromium.org>
  Date:   2025-02-12 (Wed, 12 Feb 2025)

  Changed paths:
    M Source/WebCore/accessibility/AccessibilityObject.cpp
    M Source/WebCore/html/HTMLInputElement.cpp
    M Source/WebCore/html/HTMLInputElement.h
    M Source/WebCore/html/TextFieldInputType.cpp
    M Source/WebCore/html/shadow/SliderThumbElement.cpp
    M Source/WebCore/rendering/RenderTheme.cpp

  Log Message:
  -----------
  Add hasDataList() method to HTMLInputElement.
https://bugs.webkit.org/show_bug.cgi?id=287537

Reviewed by Ryosuke Niwa.

This reserves list() for use in bindings, and dataList() for internal use.

Once referenceTarget is implemented, dataList() will be used to retrieve the
list-associated element, which may be inside a shadow root, while list() may
return null (see https://github.com/WICG/webcomponents/issues/1072 for
discussion).

hasDataList() checks whether a list-associated element is present, without
risking leaking shadow root internals inappropriately.

* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::hasDatalist const):
* Source/WebCore/html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::hasDataList const):
* Source/WebCore/html/HTMLInputElement.h:
* Source/WebCore/html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::handleClickEvent):
(WebCore::TextFieldInputType::showPicker):
(WebCore::TextFieldInputType::createShadowSubtree):
(WebCore::TextFieldInputType::didSetValueByUserEdit):
(WebCore::TextFieldInputType::dataListMayHaveChanged):
(WebCore::TextFieldInputType::dataListButtonElementWasClicked):
* Source/WebCore/html/shadow/SliderThumbElement.cpp:
(WebCore::RenderSliderContainer::computeLogicalHeight const):
* Source/WebCore/rendering/RenderTheme.cpp:
(WebCore::RenderTheme::hasListButton const):

Canonical link: https://commits.webkit.org/290325@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications