[webkit-changes] [WebKit/WebKit] 59129e: [IndexedDB] Remove handling for duplicate index ID

[Sihui]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 59129e9248cad910169ed9099b2d267bdb71ecfd
      https://github.com/WebKit/WebKit/commit/59129e9248cad910169ed9099b2d267bdb71ecfd
  Author: Sihui Liu <sihui_liu at apple.com>
  Date:   2025-02-12 (Wed, 12 Feb 2025)

  Changed paths:
    M Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp
    M Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.h
    M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm
    R Tools/TestWebKitAPI/Tests/WebKitCocoa/IndexUpgradeWithMultipleIndicesHaveSameID.sqlite3

  Log Message:
  -----------
  [IndexedDB] Remove handling for duplicate index ID
https://bugs.webkit.org/show_bug.cgi?id=287574
rdar://144716381

Reviewed by Brady Eidson.

This code was added in 229875 at main, when we had an issue that WebKit might generate indexes with the same ID. The issue
has been fixed for a long time so we don't expect database to have index with same ID now. Instead of trying to handle
duplicate index ID, we will just return an error. This enables us to remove one case of extracting index key from
SerializedScriptValue in network process.

* Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
(WebCore::IDBServer::SQLiteIDBBackingStore::extractExistingDatabaseInfo):
(WebCore::IDBServer::SQLiteIDBBackingStore::removeExistingIndex): Deleted.
(WebCore::IDBServer::SQLiteIDBBackingStore::addExistingIndex): Deleted.
(WebCore::IDBServer::SQLiteIDBBackingStore::handleDuplicateIndexIDs): Deleted.
* Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.h:
* Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
(TEST(IndexedDB, IndexUpgradeToV2WithMultipleIndices)):
(TEST(IndexedDB, IndexUpgradeToV2WithMultipleIndicesHaveSameID)): Deleted.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/IndexUpgradeWithMultipleIndicesHaveSameID.sqlite3: Removed.

Canonical link: https://commits.webkit.org/290319@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications