[webkit-changes] [WebKit/WebKit] 297e7b: Address safer C++ static analysis warnings in Filt...

Chris Dumez noreply at github.com
Wed Feb 12 18:57:02 PST 2025 

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 297e7b2e8f5550fa766974ea8574ffa4326140ba
      https://github.com/WebKit/WebKit/commit/297e7b2e8f5550fa766974ea8574ffa4326140ba
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2025-02-12 (Wed, 12 Feb 2025)

  Changed paths:
    M Source/WebCore/SaferCPPExpectations/NoUncountedMemberCheckerExpectations
    M Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
    M Source/WebCore/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations
    M Source/WebCore/platform/graphics/PixelBuffer.h
    M Source/WebCore/platform/graphics/coreimage/FEColorMatrixCoreImageApplier.mm
    M Source/WebCore/platform/graphics/coreimage/FEComponentTransferCoreImageApplier.mm
    M Source/WebCore/platform/graphics/coreimage/SourceGraphicCoreImageApplier.mm
    M Source/WebCore/platform/graphics/cpu/arm/filters/FEBlendNeonApplier.cpp
    M Source/WebCore/platform/graphics/cpu/arm/filters/FECompositeNeonArithmeticApplier.cpp
    M Source/WebCore/platform/graphics/filters/LightSource.h
    M Source/WebCore/platform/graphics/filters/skia/FEColorMatrixSkiaApplier.cpp
    M Source/WebCore/platform/graphics/filters/skia/FEComponentTransferSkiaApplier.cpp
    M Source/WebCore/platform/graphics/filters/skia/FEDropShadowSkiaApplier.cpp
    M Source/WebCore/platform/graphics/filters/skia/FEGaussianBlurSkiaApplier.cpp
    M Source/WebCore/platform/graphics/filters/skia/SourceGraphicSkiaApplier.cpp
    M Source/WebCore/platform/graphics/filters/software/FEBlendSoftwareApplier.cpp
    M Source/WebCore/platform/graphics/filters/software/FEColorMatrixSoftwareApplier.cpp
    M Source/WebCore/platform/graphics/filters/software/FEComponentTransferSoftwareApplier.cpp
    M Source/WebCore/platform/graphics/filters/software/FECompositeSoftwareApplier.cpp
    M Source/WebCore/platform/graphics/filters/software/FECompositeSoftwareArithmeticApplier.cpp
    M Source/WebCore/platform/graphics/filters/software/FEConvolveMatrixSoftwareApplier.cpp
    M Source/WebCore/platform/graphics/filters/software/FEConvolveMatrixSoftwareApplier.h
    M Source/WebCore/platform/graphics/filters/software/FEDisplacementMapSoftwareApplier.cpp
    M Source/WebCore/platform/graphics/filters/software/FEDropShadowSoftwareApplier.cpp
    M Source/WebCore/platform/graphics/filters/software/FEGaussianBlurSoftwareApplier.cpp
    M Source/WebCore/platform/graphics/filters/software/FEImageSoftwareApplier.cpp
    M Source/WebCore/platform/graphics/filters/software/FELightingSoftwareApplier.cpp
    M Source/WebCore/platform/graphics/filters/software/FELightingSoftwareApplier.h
    M Source/WebCore/platform/graphics/filters/software/FELightingSoftwareApplierInlines.h
    M Source/WebCore/platform/graphics/filters/software/FELightingSoftwareParallelApplier.cpp
    M Source/WebCore/platform/graphics/filters/software/FEMorphologySoftwareApplier.cpp
    M Source/WebCore/platform/graphics/filters/software/FEMorphologySoftwareApplier.h
    M Source/WebCore/platform/graphics/filters/software/FEOffsetSoftwareApplier.cpp
    M Source/WebCore/platform/graphics/filters/software/FETileSoftwareApplier.cpp
    M Source/WebCore/platform/graphics/filters/software/FETurbulenceSoftwareApplier.cpp
    M Source/WebCore/platform/graphics/filters/software/FETurbulenceSoftwareApplier.h
    M Source/WebCore/platform/graphics/filters/software/SourceAlphaSoftwareApplier.cpp
    M Source/WebCore/platform/graphics/filters/software/SourceGraphicSoftwareApplier.cpp

  Log Message:
  -----------
  Address safer C++ static analysis warnings in Filter Applier classes
https://bugs.webkit.org/show_bug.cgi?id=287460

Reviewed by Darin Adler.

* Source/WebCore/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations:
* Source/WebCore/platform/graphics/coreimage/FEColorMatrixCoreImageApplier.mm:
(WebCore::FEColorMatrixCoreImageApplier::apply const):
* Source/WebCore/platform/graphics/coreimage/FEComponentTransferCoreImageApplier.mm:
(WebCore::FEComponentTransferCoreImageApplier::apply const):
* Source/WebCore/platform/graphics/coreimage/SourceGraphicCoreImageApplier.mm:
(WebCore::SourceGraphicCoreImageApplier::apply const):
* Source/WebCore/platform/graphics/cpu/arm/filters/FEBlendNeonApplier.cpp:
(WebCore::FEBlendNeonApplier::apply const):
* Source/WebCore/platform/graphics/cpu/arm/filters/FECompositeNeonArithmeticApplier.cpp:
(WebCore::FECompositeNeonArithmeticApplier::apply const):
* Source/WebCore/platform/graphics/filters/skia/FEColorMatrixSkiaApplier.cpp:
(WebCore::FEColorMatrixSkiaApplier::apply const):
* Source/WebCore/platform/graphics/filters/skia/FEComponentTransferSkiaApplier.cpp:
(WebCore::FEComponentTransferSkiaApplier::apply const):
* Source/WebCore/platform/graphics/filters/skia/FEDropShadowSkiaApplier.cpp:
(WebCore::FEDropShadowSkiaApplier::apply const):
* Source/WebCore/platform/graphics/filters/skia/FEGaussianBlurSkiaApplier.cpp:
(WebCore::FEGaussianBlurSkiaApplier::apply const):
* Source/WebCore/platform/graphics/filters/skia/SourceGraphicSkiaApplier.cpp:
(WebCore::SourceGraphicSkiaApplier::apply const):
* Source/WebCore/platform/graphics/filters/software/FEBlendSoftwareApplier.cpp:
(WebCore::FEBlendSoftwareApplier::apply const):
* Source/WebCore/platform/graphics/filters/software/FEColorMatrixSoftwareApplier.cpp:
(WebCore::FEColorMatrixSoftwareApplier::apply const):
* Source/WebCore/platform/graphics/filters/software/FEComponentTransferSoftwareApplier.cpp:
(WebCore::FEComponentTransferSoftwareApplier::apply const):
* Source/WebCore/platform/graphics/filters/software/FECompositeSoftwareApplier.cpp:
(WebCore::FECompositeSoftwareApplier::apply const):
* Source/WebCore/platform/graphics/filters/software/FECompositeSoftwareArithmeticApplier.cpp:
(WebCore::FECompositeSoftwareArithmeticApplier::apply const):
* Source/WebCore/platform/graphics/filters/software/FEConvolveMatrixSoftwareApplier.cpp:
(WebCore::FEConvolveMatrixSoftwareApplier::setInteriorPixels):
(WebCore::FEConvolveMatrixSoftwareApplier::setOuterPixels):
(WebCore::FEConvolveMatrixSoftwareApplier::apply const):
* Source/WebCore/platform/graphics/filters/software/FEConvolveMatrixSoftwareApplier.h:
* Source/WebCore/platform/graphics/filters/software/FEDisplacementMapSoftwareApplier.cpp:
(WebCore::FEDisplacementMapSoftwareApplier::apply const):
* Source/WebCore/platform/graphics/filters/software/FEDropShadowSoftwareApplier.cpp:
(WebCore::FEDropShadowSoftwareApplier::apply const):
* Source/WebCore/platform/graphics/filters/software/FEGaussianBlurSoftwareApplier.cpp:
(WebCore::FEGaussianBlurSoftwareApplier::apply const):
* Source/WebCore/platform/graphics/filters/software/FEImageSoftwareApplier.cpp:
(WebCore::FEImageSoftwareApplier::apply const):
* Source/WebCore/platform/graphics/filters/software/FELightingSoftwareApplier.cpp:
(WebCore::FELightingSoftwareApplier::setPixelInternal):
(WebCore::FELightingSoftwareApplier::setPixel):
(WebCore::FELightingSoftwareApplier::applyPlatform const):
(WebCore::FELightingSoftwareApplier::apply const):
* Source/WebCore/platform/graphics/filters/software/FELightingSoftwareApplier.h:
* Source/WebCore/platform/graphics/filters/software/FELightingSoftwareApplierInlines.h:
(WebCore::FELightingSoftwareApplier::LightingData::topLeftNormal const):
(WebCore::FELightingSoftwareApplier::LightingData::topRowNormal const):
(WebCore::FELightingSoftwareApplier::LightingData::topRightNormal const):
(WebCore::FELightingSoftwareApplier::LightingData::leftColumnNormal const):
(WebCore::FELightingSoftwareApplier::LightingData::interiorNormal const):
(WebCore::FELightingSoftwareApplier::LightingData::rightColumnNormal const):
(WebCore::FELightingSoftwareApplier::LightingData::bottomLeftNormal const):
(WebCore::FELightingSoftwareApplier::LightingData::bottomRowNormal const):
(WebCore::FELightingSoftwareApplier::LightingData::bottomRightNormal const):
* Source/WebCore/platform/graphics/filters/software/FELightingSoftwareParallelApplier.cpp:
(WebCore::FELightingSoftwareParallelApplier::applyPlatformPaint):
* Source/WebCore/platform/graphics/filters/software/FEMorphologySoftwareApplier.cpp:
(WebCore::FEMorphologySoftwareApplier::applyPlatformGeneric):
(WebCore::FEMorphologySoftwareApplier::apply const):
* Source/WebCore/platform/graphics/filters/software/FEMorphologySoftwareApplier.h:
* Source/WebCore/platform/graphics/filters/software/FEOffsetSoftwareApplier.cpp:
(WebCore::FEOffsetSoftwareApplier::apply const):
* Source/WebCore/platform/graphics/filters/software/FETileSoftwareApplier.cpp:
(WebCore::FETileSoftwareApplier::apply const):
* Source/WebCore/platform/graphics/filters/software/FETurbulenceSoftwareApplier.cpp:
(WebCore::FETurbulenceSoftwareApplier::applyPlatformWorker):
(WebCore::FETurbulenceSoftwareApplier::apply const):
* Source/WebCore/platform/graphics/filters/software/FETurbulenceSoftwareApplier.h:
* Source/WebCore/platform/graphics/filters/software/SourceAlphaSoftwareApplier.cpp:
(WebCore::SourceAlphaSoftwareApplier::apply const):
* Source/WebCore/platform/graphics/filters/software/SourceGraphicSoftwareApplier.cpp:
(WebCore::SourceGraphicSoftwareApplier::apply const):

Canonical link: https://commits.webkit.org/290314@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications

More information about the webkit-changes mailing list