[webkit-changes] [WebKit/WebKit] e11a47: REGRESSION:(289950 at main)[macOS]: http/tests/webarc...

Sihui noreply at github.com
Wed Feb 12 16:06:45 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e11a47ee2628ebd5ee07512170534d8609da0141
      https://github.com/WebKit/WebKit/commit/e11a47ee2628ebd5ee07512170534d8609da0141
  Author: Sihui Liu <sihui_liu at apple.com>
  Date:   2025-02-12 (Wed, 12 Feb 2025)

  Changed paths:
    M LayoutTests/http/tests/webarchive/cross-origin-stylesheet-crash.html
    A LayoutTests/http/tests/webarchive/test-css-url-encoding-expected.txt
    A LayoutTests/http/tests/webarchive/test-css-url-encoding-shift-jis-expected.txt
    M LayoutTests/http/tests/webarchive/test-css-url-encoding-shift-jis.html
    A LayoutTests/http/tests/webarchive/test-css-url-encoding-utf-8-expected.txt
    M LayoutTests/http/tests/webarchive/test-css-url-encoding-utf-8.html
    M LayoutTests/http/tests/webarchive/test-css-url-encoding.html
    A LayoutTests/http/tests/webarchive/test-preload-resources-expected.txt
    M LayoutTests/http/tests/webarchive/test-preload-resources.html
    M LayoutTests/platform/mac-wk2/TestExpectations
    M LayoutTests/platform/mac/http/tests/webarchive/cross-origin-stylesheet-crash-expected.txt

  Log Message:
  -----------
  REGRESSION:(289950 at main)[macOS]: http/tests/webarchive tests are a flaky failures with image failures(failure in EWS)
https://bugs.webkit.org/show_bug.cgi?id=287509
rdar://144639388

Reviewed by Ryosuke Niwa.

In 289950 at main, we started to capture some memory-cached files in webarchive, which helps ensure high fidelity of the
result. This change makes webarchive content less deterministic -- it will be dependent on what is availalbe in memory
cache. And this causes webarhive tests to be flaky because we compare the running result with a fixed content. To fix
the flakiness, now we clear memory cache before running the webarchive tests.

* LayoutTests/http/tests/webarchive/cross-origin-stylesheet-crash.html:
* LayoutTests/http/tests/webarchive/test-css-url-encoding-expected.txt: Added.
* LayoutTests/http/tests/webarchive/test-css-url-encoding-shift-jis-expected.txt: Added.
* LayoutTests/http/tests/webarchive/test-css-url-encoding-shift-jis.html:
* LayoutTests/http/tests/webarchive/test-css-url-encoding-utf-8-expected.txt: Added.
* LayoutTests/http/tests/webarchive/test-css-url-encoding-utf-8.html:
* LayoutTests/http/tests/webarchive/test-css-url-encoding.html:
* LayoutTests/http/tests/webarchive/test-preload-resources-expected.txt: Added.
* LayoutTests/http/tests/webarchive/test-preload-resources.html:
* LayoutTests/platform/mac-wk2/TestExpectations:
* LayoutTests/platform/mac/http/tests/webarchive/cross-origin-stylesheet-crash-expected.txt:

Canonical link: https://commits.webkit.org/290309@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list