[webkit-changes] [WebKit/WebKit] 6c992d: Remove WebCoreDecompressionSession queue management.
Jean-Yves Avenard
noreply at github.com
Wed Feb 12 15:54:46 PST 2025
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 6c992def912e01b0fb737224cae08fb323b729a4
https://github.com/WebKit/WebKit/commit/6c992def912e01b0fb737224cae08fb323b729a4
Author: Jean-Yves Avenard <jya at apple.com>
Date: 2025-02-12 (Wed, 12 Feb 2025)
Changed paths:
M Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h
M Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm
M Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.h
M Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm
M Source/WebCore/platform/graphics/cocoa/VideoMediaSampleRenderer.mm
M Source/WebCore/platform/graphics/cocoa/WebCoreDecompressionSession.h
M Source/WebCore/platform/graphics/cocoa/WebCoreDecompressionSession.mm
Log Message:
-----------
Remove WebCoreDecompressionSession queue management.
https://bugs.webkit.org/show_bug.cgi?id=283565
rdar://140417110
Reviewed by Jer Noble.
Remove no longer used code.
Frame queue management is now done in the VideoMediaSampleRenderer and
a WebCoreDecompressionSession is only ever used to decode a single frame
at a time.
No change in observable behaviour. Covered by existing tests.
* Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h: Remove unused forward declaration
* Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm: Remove unused header.
* Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.h: Remove unused forward declaration
* Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm: Remove unused header.
* Source/WebCore/platform/graphics/cocoa/VideoMediaSampleRenderer.mm:
(WTF::CFTypeTrait<CMSampleBufferRef>::typeID): Move code from WebCoreDecompressionSession
(WebCore::getDecodeTime): Move code from WebCoreDecompressionSession
(WebCore::getPresentationTime): Move code from WebCoreDecompressionSession
(WebCore::getDuration): Move code from WebCoreDecompressionSession
(WebCore::compareBuffers): Move code from WebCoreDecompressionSession
(WebCore::createBufferQueue): Move code from WebCoreDecompressionSession
(WebCore::VideoMediaSampleRenderer::initializeDecompressionSession):
* Source/WebCore/platform/graphics/cocoa/WebCoreDecompressionSession.h:
* Source/WebCore/platform/graphics/cocoa/WebCoreDecompressionSession.mm:
(WebCore::WebCoreDecompressionSession::WebCoreDecompressionSession):
(WebCore::WebCoreDecompressionSession::invalidate):
(WebCore::WebCoreDecompressionSession::ensureDecompressionSessionForSample):
(WebCore::WebCoreDecompressionSession::decodeSampleInternal):
(WebCore::WebCoreDecompressionSession::handleDecompressionOutput):
(WebCore::WebCoreDecompressionSession::flush):
(WTF::CFTypeTrait<CMSampleBufferRef>::typeID): Deleted.
(WebCore::WebCoreDecompressionSession::setTimebase): Deleted.
(WebCore::WebCoreDecompressionSession::setTimebaseWithLockHeld): Deleted.
(WebCore::WebCoreDecompressionSession::timebase const): Deleted.
(WebCore::WebCoreDecompressionSession::maybeBecomeReadyForMoreMediaData): Deleted.
(WebCore::WebCoreDecompressionSession::createBufferQueue): Deleted.
(WebCore::WebCoreDecompressionSession::enqueueSample): Deleted.
(WebCore::WebCoreDecompressionSession::shouldDecodeSample): Deleted.
(WebCore::WebCoreDecompressionSession::enqueueCompressedSample): Deleted.
(WebCore::WebCoreDecompressionSession::maybeDecodeNextSample): Deleted.
(WebCore::WebCoreDecompressionSession::setErrorListener): Deleted.
(WebCore::WebCoreDecompressionSession::removeErrorListener): Deleted.
(WebCore::WebCoreDecompressionSession::getFirstVideoFrame): Deleted.
(WebCore::WebCoreDecompressionSession::automaticDequeue): Deleted.
(WebCore::WebCoreDecompressionSession::enqueueDecodedSample): Deleted.
(WebCore::WebCoreDecompressionSession::isReadyForMoreMediaData const): Deleted.
(WebCore::WebCoreDecompressionSession::requestMediaDataWhenReady): Deleted.
(WebCore::WebCoreDecompressionSession::stopRequestingMediaData): Deleted.
(WebCore::WebCoreDecompressionSession::notifyWhenHasAvailableVideoFrame): Deleted.
(WebCore::WebCoreDecompressionSession::imageForTime): Deleted.
(WebCore::WebCoreDecompressionSession::getDecodeTime): Deleted.
(WebCore::WebCoreDecompressionSession::getPresentationTime): Deleted.
(WebCore::WebCoreDecompressionSession::getDuration): Deleted.
(WebCore::WebCoreDecompressionSession::compareBuffers): Deleted.
(WebCore::WebCoreDecompressionSession::resetQosTier): Deleted.
(WebCore::WebCoreDecompressionSession::increaseQosTier): Deleted.
(WebCore::WebCoreDecompressionSession::decreaseQosTier): Deleted.
(WebCore::WebCoreDecompressionSession::updateQosWithDecodeTimeStatistics): Deleted.
Canonical link: https://commits.webkit.org/290307@main
To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications
More information about the webkit-changes
mailing list