[webkit-changes] [WebKit/WebKit] c79a81: Selection fails to update during autoscrolling as ...

[megangardner]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c79a81698e5532e5f3a8de9720e3f640a674e683
      https://github.com/WebKit/WebKit/commit/c79a81698e5532e5f3a8de9720e3f640a674e683
  Author: Megan Gardner <megan_gardner at apple.com>
  Date:   2025-02-12 (Wed, 12 Feb 2025)

  Changed paths:
    M Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm
    M Source/WebKit/UIProcess/ios/WKContentViewInteraction.h
    M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm

  Log Message:
  -----------
  Selection fails to update during autoscrolling as well as keyboard scrolling.
https://bugs.webkit.org/show_bug.cgi?id=287454
rdar://144581646

Reviewed by Aditya Keerthi and Wenson Hsieh.

When a user uses the keyboard or the autoscroll functionality to
scroll a view while a selection is happening, they don't generate
additional touches unless their finger moves. Thus if you
hold your finger still while scrolling, the selection doesn't update.
In order to for a selection to update, we keep track of the position of
the last touch and use it to update the selection when the view is scrolled.

* Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:
(-[WKWebView scrollViewDidScroll:]):
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.h:
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView updateSelection]):
(-[WKContentView changeSelectionWithTouchAt:withSelectionTouch:baseIsStart:withFlags:]):
(-[WKContentView updateSelectionWithTouchAt:withSelectionTouch:baseIsStart:withFlags:]):

Canonical link: https://commits.webkit.org/290299@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications