[webkit-changes] [WebKit/WebKit] 309557: Unreviewed, fix the non-unified-source build in WK...

Wenson Hsieh noreply at github.com
Wed Feb 12 12:27:20 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 309557da4f2e209dd38024422b24af7223d18860
      https://github.com/WebKit/WebKit/commit/309557da4f2e209dd38024422b24af7223d18860
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2025-02-12 (Wed, 12 Feb 2025)

  Changed paths:
    M Source/WebKit/UIProcess/Cocoa/SOAuthorization/WKSOAuthorizationDelegate.h
    M Source/WebKit/UIProcess/Cocoa/SOAuthorization/WKSOAuthorizationDelegate.mm

  Log Message:
  -----------
  Unreviewed, fix the non-unified-source build in WKSOAuthorizationDelegate.mm

`WKSOAuthorizationDelegate.h` forward declares `WebKit::SOAuthorizationSession`, but it also
declares `RefPtr<WebKit::SOAuthorizationSession> _session;` as a @package ivar in the interface,
which requires explicit template instantiation in the header; this only happens to work right now
due to source unification ordering.

Fix this by moving `_session` out of the @package section, and into the @implementation instead like
a normal ObjC ivar.

* Source/WebKit/UIProcess/Cocoa/SOAuthorization/WKSOAuthorizationDelegate.h:
* Source/WebKit/UIProcess/Cocoa/SOAuthorization/WKSOAuthorizationDelegate.mm:

Canonical link: https://commits.webkit.org/290292@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list