[webkit-changes] [WebKit/WebKit] b83c03: Web Extension icon errors are duplicated in errors...

[Timothy Hatcher]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b83c037519e94862ad4f0f39c85cfc8c2b17f8b1
      https://github.com/WebKit/WebKit/commit/b83c037519e94862ad4f0f39c85cfc8c2b17f8b1
  Author: Timothy Hatcher <timothy at apple.com>
  Date:   2025-02-12 (Wed, 12 Feb 2025)

  Changed paths:
    M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm
    M Source/WebKit/UIProcess/Extensions/WebExtension.cpp
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtension.mm

  Log Message:
  -----------
  Web Extension icon errors are duplicated in errors array.
https://webkit.org/b/287497
rdar://144623162

Reviewed by Brian Weinstein.

Correct how duplicate errors are avoided now that they are stored in a Vector
of API::Error objects and not an NSArray of NSError objects.

Added a regression test.

* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm:
(WebKit::WebExtension::recordError): Compare descriptions.
* Source/WebKit/UIProcess/Extensions/WebExtension.cpp:
(WebKit::WebExtension::actionIcon): Drive-by whitespace fix.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtension.mm:
(TestWebKitAPI::TEST(WKWebExtension, IconErrorsOnce)): Added.

Canonical link: https://commits.webkit.org/290269@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications