[webkit-changes] [WebKit/WebKit] 379956: REGRESSION(283286.393 at safari-7620-branch): Crash i...

[Charlie Wolfe]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 379956fc242a6bad0a3d8d665398834a25c22e7a
      https://github.com/WebKit/WebKit/commit/379956fc242a6bad0a3d8d665398834a25c22e7a
  Author: Charlie Wolfe <charliew at apple.com>
  Date:   2025-02-11 (Tue, 11 Feb 2025)

  Changed paths:
    M Source/WebCore/page/Page.cpp
    M Source/WebCore/page/ResourceUsageOverlay.h

  Log Message:
  -----------
  REGRESSION(283286.393 at safari-7620-branch): Crash in `PageOverlayController::uninstallPageOverlay`
https://bugs.webkit.org/show_bug.cgi?id=283832
rdar://140529810

Reviewed by Chris Dumez.

283286.393 at safari-7620-branch made the ResourceUsageOverlay destructor access the page it was holding
instead of the page held by the page’s mainframe. This was a behavior change because the page destructor
nulls the page held by the mainframe, so we would not try to uninstall the overlay if page destruction
has begun.

This change clears the page held by ResourceUsageOverlay in the page’s destructor to avoid uninstalling
the overlay during page destruction.

* Source/WebCore/page/Page.cpp:
(WebCore::Page::~Page):
* Source/WebCore/page/ResourceUsageOverlay.h:

Originally-landed-as: 283286.535 at safari-7620-branch (6bfd37a9ea77). rdar://144654097
Canonical link: https://commits.webkit.org/290254@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications