[webkit-changes] [WebKit/WebKit] 58b0e5: REGRESSION(286147 at main): text-decoration-thickness...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 58b0e56a3633a51d923f4507d6f9b7445275faa8
      https://github.com/WebKit/WebKit/commit/58b0e56a3633a51d923f4507d6f9b7445275faa8
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2025-02-11 (Tue, 11 Feb 2025)

  Changed paths:
    A LayoutTests/fast/inline/incorrect-line-through-thickness-expected.html
    A LayoutTests/fast/inline/incorrect-line-through-thickness.html
    M Source/WebCore/rendering/TextBoxPainter.cpp
    M Source/WebCore/rendering/TextBoxPainter.h

  Log Message:
  -----------
  REGRESSION(286147 at main): text-decoration-thickness style is not reflected on phanpy.social
https://bugs.webkit.org/show_bug.cgi?id=287498
<rdar://144529057>

Reviewed by Antti Koivisto.

Let's use the decorating box way to collect text-decoration-thickness style (which technically the same as prior to 286147 at main where the
RenderText did return its parent style).

* LayoutTests/fast/inline/incorrect-line-through-thickness-expected.html: Added.
* LayoutTests/fast/inline/incorrect-line-through-thickness.html: Added.
* Source/WebCore/rendering/TextBoxPainter.cpp:
(WebCore::TextBoxPainter::collectDecoratingBoxesForBackgroundPainting):
(WebCore::TextBoxPainter::paintBackgroundDecorations):
(WebCore::decoratingBoxStyle):
(WebCore::TextBoxPainter::paintForegroundDecorations):
(WebCore::TextBoxPainter::collectDecoratingBoxesForTextBox): Deleted.
* Source/WebCore/rendering/TextBoxPainter.h:

Canonical link: https://commits.webkit.org/290249@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications