[webkit-changes] [WebKit/WebKit] b1b8f9: REGRESSION( SequoiaC ): [ Debug SequoiaC+ ] TestWe...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b1b8f97614b709797b226fd438d6d18e28c4fd50
      https://github.com/WebKit/WebKit/commit/b1b8f97614b709797b226fd438d6d18e28c4fd50
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2025-02-11 (Tue, 11 Feb 2025)

  Changed paths:
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCandidateTests.mm

  Log Message:
  -----------
  REGRESSION( SequoiaC ): [ Debug SequoiaC+ ] TestWebKitAPI.WKWebViewCandidateTests.ShouldNotRequestCandidatesInPasswordField is a constant timeout
https://bugs.webkit.org/show_bug.cgi?id=287496
rdar://144628446

Reviewed by Abrar Rahman Protyasha.

Adjust several API tests to be more robust when inserting text; rather than sending synthesized key
events to insert text into editable fields, we instead use `-insertText:` and wait for the next
presentation update to achieve the same effect. These tests don't actually depend on key events
(just inserting text via editing commands), so `-insertText:` is sufficient.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCandidateTests.mm:
(-[CandidateTestWebView insertCandidatesAndWaitForResponse:range:]):
(TEST(WKWebViewCandidateTests, ShouldNotRequestCandidatesInPasswordField)):
(TEST(WKWebViewCandidateTests, ShouldRequestCandidatesInTextField)):

Canonical link: https://commits.webkit.org/290241@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications