[webkit-changes] [WebKit/WebKit] e54797: [WebGPUSwift] Swift Interop should use char16_t fo...

[nmahendru]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e547970c6e4dc4073024dd735962c8994d3e4377
      https://github.com/WebKit/WebKit/commit/e547970c6e4dc4073024dd735962c8994d3e4377
  Author: Nitin Mahendru <nitinmahendru at apple.com>
  Date:   2025-02-11 (Tue, 11 Feb 2025)

  Changed paths:
    M Source/WTF/wtf/text/WTFString.h
    M Source/WebGPU/Configurations/WebGPU.xcconfig

  Log Message:
  -----------
  [WebGPUSwift] Swift Interop should use char16_t for UCHAR
rdar://144635361
https://bugs.webkit.org/show_bug.cgi?id=287504

Reviewed by Geoffrey Garen.

In Source/WTF/icu/unicode/umachine.h we are defining UCHAR_TYPE as char16_t
overriding the system definition of uint16_t.
Swift Interop(Clang importer) is using the system header and thus does not like:
`inline String operator""_str(const UChar* characters, size_t length)`
because the first argument is interpreted as `const unsigned short * characters` which is not a
valid type for string literals.
This change makes Clang Importer use the same definition as WebKit and this I can now let
the Swift code compile this function.

* Source/WTF/wtf/text/WTFString.h:
(WTF::StringLiterals::operator_str):
* Source/WebGPU/Configurations/WebGPU.xcconfig:

Canonical link: https://commits.webkit.org/290240@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications