[webkit-changes] [WebKit/WebKit] a6aba3: Donate media playback information to Screen Time

Jessica Cheung noreply at github.com
Tue Feb 11 13:35:20 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a6aba3e394b3b74f9558859bf64de9d02c2923b6
      https://github.com/WebKit/WebKit/commit/a6aba3e394b3b74f9558859bf64de9d02c2923b6
  Author: Jessica Cheung <jcheung23 at apple.com>
  Date:   2025-02-11 (Tue, 11 Feb 2025)

  Changed paths:
    M Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.h
    M Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.mm
    M Source/WebKit/UIProcess/Cocoa/VideoPresentationManagerProxy.mm
    M Source/WebKit/UIProcess/PageClient.h
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Source/WebKit/UIProcess/WebPageProxy.h
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/ScreenTime.mm

  Log Message:
  -----------
  Donate media playback information to Screen Time
https://bugs.webkit.org/show_bug.cgi?id=287168
rdar://140439198

Reviewed by Aditya Keerthi.

Add support for URLIsPictureInPicture and URLIsPlayingVideo on STWebpageController.
Add API tests for URLIsPlayingVideo and URLIsPictureInPicture.
Currently, there is only a mac test for URLIsPictureInPicture. This is because
TestWebKitAPI is not a UI application so can't actually go into PiP.

* Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.h:
* Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.mm:
(WebKit::PageClientImplCocoa::setURLIsPictureInPictureForScreenTime):
(WebKit::PageClientImplCocoa::setURLIsPlayingVideoForScreenTime):
* Source/WebKit/UIProcess/Cocoa/VideoPresentationManagerProxy.mm:
(WebKit::VideoPresentationManagerProxy::hasVideoInPictureInPictureDidChange):
* Source/WebKit/UIProcess/PageClient.h:
(WebKit::PageClient::setURLIsPictureInPictureForScreenTime):
(WebKit::PageClient::setURLIsPlayingVideoForScreenTime):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::hasVideoInPictureInPictureDidChange):
(WebKit::WebPageProxy::updatePlayingMediaDidChange):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/ScreenTime.mm:
(TEST(ScreenTime, URLIsPlayingVideo)):
(-[STPictureInPictureUIDelegate _webView:hasVideoInPictureInPictureDidChange:]):
(-[STPictureInPictureUIDelegate userContentController:didReceiveScriptMessage:]):
(TEST(ScreenTime, URLIsPictureInPictureMacos)):

Canonical link: https://commits.webkit.org/290235@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list