[webkit-changes] [WebKit/WebKit] 83b8e1: [WebGPUSwift] replace all other Metal specific fun...

[nmahendru]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 83b8e1d37fa1c1c39f87f84d5abb423e1930fc3f
      https://github.com/WebKit/WebKit/commit/83b8e1d37fa1c1c39f87f84d5abb423e1930fc3f
  Author: Nitin Mahendru <nitinmahendru at apple.com>
  Date:   2025-02-11 (Tue, 11 Feb 2025)

  Changed paths:
    M Source/WebGPU/WebGPU.xcodeproj/project.pbxproj
    M Source/WebGPU/WebGPU/Buffer.swift
    M Source/WebGPU/WebGPU/CommandBuffer.h
    M Source/WebGPU/WebGPU/CommandEncoder.h
    M Source/WebGPU/WebGPU/CommandEncoder.mm
    M Source/WebGPU/WebGPU/CommandEncoder.swift
    M Source/WebGPU/WebGPU/CommandsMixin.h
    M Source/WebGPU/WebGPU/Device.h
    M Source/WebGPU/WebGPU/Device.mm
    A Source/WebGPU/WebGPU/Internal/Logging.cpp
    A Source/WebGPU/WebGPU/Internal/Logging.h
    M Source/WebGPU/WebGPU/Internal/WebGPUSwiftInternal.h
    M Source/WebGPU/WebGPU/SwiftCXXThunk.h

  Log Message:
  -----------
  [WebGPUSwift] replace all other Metal specific functions in Command Encoder
rdar://144317197
https://bugs.webkit.org/show_bug.cgi?id=287165

Reviewed by Mike Wyrzykowski.

1-to-1 replacement of the below:

1. CommandEncoder::createSimplePso
2. CommandEncoder::runClearEncoder
3. CommandEncoder::clearTextureIfNeeded
4. CommandEncoder::finish

* Source/WebGPU/WebGPU.xcodeproj/project.pbxproj:
* Source/WebGPU/WebGPU/Buffer.swift:
* Source/WebGPU/WebGPU/CommandBuffer.h:
(refCommandBuffer):
(derefCommandBuffer):
* Source/WebGPU/WebGPU/CommandEncoder.h:
(WebGPU::CommandEncoder::create):
(WebGPU::CommandEncoder::setEncoderState):
(WebGPU::CommandEncoder::getEncoderState):
(WebGPU::CommandEncoder::encoderStateNameWrapper):
* Source/WebGPU/WebGPU/CommandEncoder.mm:
(WebGPU::CommandEncoder::waitForCommandBufferCompletion):
(WebGPU::CommandEncoder::encoderIsCurrent const):
* Source/WebGPU/WebGPU/CommandEncoder.swift:
(CommandEncoder_runClearEncoder_thunk(_:attachmentsToClear:depthStencilAttachmentToClear:depthAttachmentToClear:stencilAttachmentToClear:depthClearValue:stencilClearValue:existingEncoder:)):
(CommandEncoder_clearTextureIfNeeded_thunk(_:destination:slice:)):
(CommandEncoder_finish_thunk(_:descriptor:)):
(WebGPU.validateFinishError):
(WebGPU.finish(_:)):
(WebGPU.clearTextureIfNeeded(_:slice:)):
(WebGPU.clearTextureIfNeeded(_:slice:device:blitCommandEncoder:)):
(WebGPU.clearTextureIfNeeded(_:_:_:_:_:)):
(WebGPU.sourceBytesPerRow):
(WebGPU.didOverflow):
(WebGPU.checkedBytesPerImage):
(WebGPU.sourceSize):
(WebGPU.sourceBytesPerImage):
(WebGPU.options):
(WebGPU.runClearEncoder(_:depthStencilAttachmentToClear:depthAttachmentToClear:stencilAttachmentToClear:depthClearValue:stencilClearValue:existingEncoder:)):
(WebGPU.errorValidatingCopyBufferToBuffer(_:sourceOffset:destination:destinationOffset:size:)):
(WebGPU.errorValidatingCopyTextureToTexture(_:destination:copySize:)):
(WebGPU.errorValidatingCopyTextureToBuffer(_:destination:copySize:)):
(WebGPU.errorValidatingCopyBufferToTexture(_:destination:copySize:)):
(WebGPU.loadAction(_:)):
(WebGPU.beginRenderPass(_:)):
(WebGPU.copyTextureToBuffer(_:destination:copySize:)):
(WebGPU.copyBufferToTexture(_:destination:copySize:)):
(WebGPU.copyTextureToTexture(_:destination:copySize:)):
* Source/WebGPU/WebGPU/CommandsMixin.h:
* Source/WebGPU/WebGPU/Device.h:
* Source/WebGPU/WebGPU/Device.mm:
(WebGPU::Device::create):
(WebGPU::Device::Device):
* Source/WebGPU/WebGPU/Internal/Logging.cpp: Copied from Source/WebGPU/WebGPU/CommandsMixin.h.
* Source/WebGPU/WebGPU/Internal/Logging.h: Copied from Source/WebGPU/WebGPU/CommandsMixin.h.
* Source/WebGPU/WebGPU/Internal/WebGPUSwiftInternal.h:
(WebGPU_Internal::logString):
(WebGPU_Internal::convertWTFStringToNSString):
(WebGPU_Internal::commandBufferThreadSafeWeakPtr):
(roundUpToMultipleOfNonPowerOfTwoCheckedUInt32UnsignedLong): Deleted.
(roundUpToMultipleOfNonPowerOfTwoUInt32UInt32): Deleted.
(checkedDifferenceSizeT): Deleted.
(isValidToUseWithTextureViewCommandEncoder): Deleted.
(isValidToUseWithQuerySetCommandEncoder): Deleted.
(isValidToUseWithBufferCommandEncoder): Deleted.
(isValidToUseWithTextureCommandEncoder): Deleted.
(clampDouble): Deleted.
(areBuffersEqual): Deleted.
* Source/WebGPU/WebGPU/SwiftCXXThunk.h:

Canonical link: https://commits.webkit.org/290231@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications