[webkit-changes] [WebKit/WebKit] c67090: Improve <input type=color alpha> performance on macOS

[Anne van Kesteren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c6709039985b45fbabb8cf2256cb1d1b00baf724
      https://github.com/WebKit/WebKit/commit/c6709039985b45fbabb8cf2256cb1d1b00baf724
  Author: Anne van Kesteren <annevk at annevk.nl>
  Date:   2025-02-11 (Tue, 11 Feb 2025)

  Changed paths:
    M LayoutTests/fast/forms/color/color-input-swatch-expected.txt
    M LayoutTests/fast/forms/color/color-input-swatch.html
    M LayoutTests/platform/mac/fast/forms/color/color-input-swatch-expected.txt
    M LayoutTests/platform/mac/fast/forms/color/input-appearance-color-expected.txt
    M Source/WebCore/html/ColorInputType.cpp
    M Source/WebCore/rendering/RenderTheme.h
    M Source/WebCore/rendering/mac/RenderThemeMac.h
    M Source/WebCore/rendering/mac/RenderThemeMac.mm

  Log Message:
  -----------
  Improve <input type=color alpha> performance on macOS
https://bugs.webkit.org/show_bug.cgi?id=286803
rdar://143955048

Reviewed by Aditya Keerthi.

Using data: URLs here resulted in annoying flickering when moving the
alpha slider quickly.

Using SVG directly in the shadow tree ran into
https://bugs.webkit.org/show_bug.cgi?id=287472 so therefore we use a
div element with a polygon clip-path. This results in additional render
layers, but websites will likely not have a lot of these controls so
that seems okay.

* LayoutTests/fast/forms/color/color-input-swatch-expected.txt:
* LayoutTests/fast/forms/color/color-input-swatch.html:
* LayoutTests/platform/mac/fast/forms/color/color-input-swatch-expected.txt:
* LayoutTests/platform/mac/fast/forms/color/input-appearance-color-expected.txt:
* Source/WebCore/html/ColorInputType.cpp:
(WebCore::ColorInputType::createShadowSubtree):
(WebCore::ColorInputType::updateColorSwatch):
* Source/WebCore/rendering/RenderTheme.h:
(WebCore::RenderTheme::createColorWellSwatchSubtree):
* Source/WebCore/rendering/mac/RenderThemeMac.h:
* Source/WebCore/rendering/mac/RenderThemeMac.mm:
(WebCore::RenderThemeMac::createColorWellSwatchSubtree):
(WebCore::RenderThemeMac::setColorWellSwatchBackground):

Canonical link: https://commits.webkit.org/290228@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications