[webkit-changes] [WebKit/WebKit] c46c3b: [SVG] Never try to construct multiple lines for sv...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c46c3b61f74ecbbeb9e7137a1cf8c661279679ce
      https://github.com/WebKit/WebKit/commit/c46c3b61f74ecbbeb9e7137a1cf8c661279679ce
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2025-02-11 (Tue, 11 Feb 2025)

  Changed paths:
    A LayoutTests/fast/svg/assert-when-trying-to-construct-multiple-lines-expected.txt
    A LayoutTests/fast/svg/assert-when-trying-to-construct-multiple-lines.html
    M Source/WebCore/rendering/LegacyLineLayout.cpp
    M Source/WebCore/rendering/line/BreakingContext.h

  Log Message:
  -----------
  [SVG] Never try to construct multiple lines for svg content
https://bugs.webkit.org/show_bug.cgi?id=287424

Reviewed by Antti Koivisto.

1. SVG content has no breakable positions (see canBreakAtThisPosition)
2. Refuse to construct subsequent lines for SVG content

* LayoutTests/fast/svg/assert-when-trying-to-construct-multiple-lines-expected.txt: Added.
* LayoutTests/fast/svg/assert-when-trying-to-construct-multiple-lines.html: Added.
* Source/WebCore/rendering/LegacyLineLayout.cpp:
(WebCore::LegacyLineLayout::constructLine):
* Source/WebCore/rendering/line/BreakingContext.h:
(WebCore::BreakingContext::canBreakAtThisPosition):
(WebCore::textBeginsWithBreakablePosition): Deleted.

Canonical link: https://commits.webkit.org/290218@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications