[webkit-changes] [WebKit/WebKit] b436f5: Address static analyzer warnings and UNSAFE_BUFFER...

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b436f5fd9c2e60d9ee82a047eb67a73e74129da2
      https://github.com/WebKit/WebKit/commit/b436f5fd9c2e60d9ee82a047eb67a73e74129da2
  Author: Geoffrey Garen <ggaren at apple.com>
  Date:   2025-02-11 (Tue, 11 Feb 2025)

  Changed paths:
    M Source/WTF/SaferCPPExpectations/NoUncountedMemberCheckerExpectations
    M Source/WTF/SaferCPPExpectations/UncountedLambdaCapturesCheckerExpectations
    M Source/WTF/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations
    M Source/WTF/wtf/ParkingLot.cpp

  Log Message:
  -----------
  Address static analyzer warnings and UNSAFE_BUFFER_USAGE in ParkingLot
https://bugs.webkit.org/show_bug.cgi?id=287446
<rdar://problem/144574023>

Reviewed by Chris Dumez.

Use FixedVector in Hashtable to avoid unsafe pointer arithmetic.

Use RefPtr instead of raw pointer for ThreadData to avoid ambiguous lifetime.
In theory all these RefPtrs are not needed, since ThreadData is per-thread
and a thread will not exit while holding a lock, but it's nice not to have to
theorize, and also pthread_exit() is a function and per-thread destruction order
is not guaranteed.

* Source/WTF/wtf/ParkingLot.cpp:
(WTF::ParkingLot::parkConditionallyImpl):
(WTF::ParkingLot::forEachImpl):

Canonical link: https://commits.webkit.org/290217@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications