[webkit-changes] [WebKit/WebKit] 818477: Update `contrast-color()` for removal of `max` par...

[Sam Weinig]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 818477725b452ce1f2b5bab79e9a70ae49fe5ff0
      https://github.com/WebKit/WebKit/commit/818477725b452ce1f2b5bab79e9a70ae49fe5ff0
  Author: Sam Weinig <sam at webkit.org>
  Date:   2025-02-11 (Tue, 11 Feb 2025)

  Changed paths:
    M LayoutTests/fast/css/color-computed-contrast-color-function-expected.txt
    M LayoutTests/fast/css/color-computed-contrast-color-function.html
    R LayoutTests/fast/css/color-invalid-contrast-color-function-expected.txt
    R LayoutTests/fast/css/color-invalid-contrast-color-function.html
    R LayoutTests/fast/css/color-valid-contrast-color-function-expected.txt
    R LayoutTests/fast/css/color-valid-contrast-color-function.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-contrast-color-function-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-contrast-color-function.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-invalid-contrast-color-function-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-invalid-contrast-color-function.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-contrast-color-function-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-contrast-color-function.html
    M Source/WebCore/css/parser/CSSPropertyParserConsumer+Color.cpp
    M Source/WebCore/css/values/color/CSSContrastColor.cpp
    M Source/WebCore/css/values/color/CSSContrastColor.h
    M Source/WebCore/css/values/color/CSSContrastColorResolver.h
    M Source/WebCore/css/values/color/CSSContrastColorSerialization.h
    M Source/WebCore/style/values/color/StyleContrastColor.cpp
    M Source/WebCore/style/values/color/StyleContrastColor.h

  Log Message:
  -----------
  Update `contrast-color()` for removal of `max` parameter
https://bugs.webkit.org/show_bug.cgi?id=287410

Reviewed by Tim Nguyen.

Updates the implementation of `contrast-color()` to match the latest
spec which removed `max` parameter (see https://github.com/w3c/csswg-drafts/pull/11654).

Also updates tests and moves the non-WPT tests to WPT, changing the
computed style tests to allow either `white` or `black` for all computed
values due to the lack of agreed upon algorithm.

To keep coverage of the algorithm in WebKit, a copy of the computed style
test was kept in css/fast that retains the specific results.

* LayoutTests/fast/css/color-computed-contrast-color-function-expected.txt:
* LayoutTests/fast/css/color-computed-contrast-color-function.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-contrast-color-function-expected.txt: Copied from LayoutTests/fast/css/color-computed-contrast-color-function-expected.txt.
* LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-contrast-color-function.html: Copied from LayoutTests/fast/css/color-computed-contrast-color-function.html.
* LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-invalid-contrast-color-function-expected.txt: Renamed from LayoutTests/fast/css/color-invalid-contrast-color-function-expected.txt.
* LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-invalid-contrast-color-function.html: Renamed from LayoutTests/fast/css/color-invalid-contrast-color-function.html.
* LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-contrast-color-function-expected.txt: Renamed LayoutTests/fast/css/color-valid-contrast-color-function-expected.txt.
* LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-contrast-color-function.html: Renamed LayoutTests/fast/css/color-valid-contrast-color-function.html.
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Color.cpp:
* Source/WebCore/css/values/color/CSSContrastColor.cpp:
* Source/WebCore/css/values/color/CSSContrastColor.h:
* Source/WebCore/css/values/color/CSSContrastColorResolver.h:
* Source/WebCore/css/values/color/CSSContrastColorSerialization.h:
* Source/WebCore/style/values/color/StyleContrastColor.cpp:
* Source/WebCore/style/values/color/StyleContrastColor.h:

Canonical link: https://commits.webkit.org/290210@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications