[webkit-changes] [WebKit/WebKit] eec67e: REGRESSION(290095 at main): [Skia] Tests are crashing...

Carlos Garcia Campos noreply at github.com
Tue Feb 11 03:07:51 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: eec67ecd7dc52062ad01e1c051f42499c036ffcd
      https://github.com/WebKit/WebKit/commit/eec67ecd7dc52062ad01e1c051f42499c036ffcd
  Author: Carlos Garcia Campos <cgarcia at igalia.com>
  Date:   2025-02-11 (Tue, 11 Feb 2025)

  Changed paths:
    M Source/WebCore/platform/graphics/filters/FilterEffect.h

  Log Message:
  -----------
  REGRESSION(290095 at main): [Skia] Tests are crashing due to assert in SingleThreadIntegralWrapper<unsigned int>::operator++()
https://bugs.webkit.org/show_bug.cgi?id=287474

Reviewed by Philippe Normand.

In 290095 at main FilterEffect was changed to use CheckedPtr which makes
filters no longer usable from different threads. We record a DisplayList
in the main thread, and replay it in worker threads for painting layers,
so we need to use CanMakeThreadSafeCheckedPtr instead.

* Source/WebCore/platform/graphics/filters/FilterEffect.h:

Canonical link: https://commits.webkit.org/290205@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list