[webkit-changes] [WebKit/WebKit] 216a46: UnifiedPDF: Unbounded page preview rendering cause...

[Kimmo Kinnunen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 216a4697632bd08c6d2c087b2009789f3f078a56
      https://github.com/WebKit/WebKit/commit/216a4697632bd08c6d2c087b2009789f3f078a56
  Author: Kimmo Kinnunen <kkinnunen at apple.com>
  Date:   2025-02-11 (Tue, 11 Feb 2025)

  Changed paths:
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/AsyncPDFRenderer.h
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/AsyncPDFRenderer.mm

  Log Message:
  -----------
  UnifiedPDF: Unbounded page preview rendering causes out of memory
https://bugs.webkit.org/show_bug.cgi?id=287232
rdar://143750712

Reviewed by Abrar Rahman Protyasha.

Limit PDF page previews render tasks to max concurrent task, similar to
rendering normal PDF layer content.

* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/AsyncPDFRenderer.h:
(WebKit::PDFPagePreviewRenderKeyHash::hash):
(WebKit::PDFPagePreviewRenderKeyHash::equal):
(WTF::HashTraits<WebKit::PDFPagePreviewRenderKey>::emptyValue):
(WTF::HashTraits<WebKit::PDFPagePreviewRenderKey>::constructDeletedValue):
(WTF::HashTraits<WebKit::PDFPagePreviewRenderKey>::isDeletedValue):
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/AsyncPDFRenderer.mm:
(WebKit::AsyncPDFRenderer::AsyncPDFRenderer):
(WebKit::renderPDFPagePreview):
(WebKit::AsyncPDFRenderer::generatePreviewImageForPage):
(WebKit::AsyncPDFRenderer::removePreviewForPage):
(WebKit::AsyncPDFRenderer::didCompletePagePreviewRender):
(WebKit::AsyncPDFRenderer::enqueueTileRenderForTileGridRepaint):
(WebKit::AsyncPDFRenderer::willRemoveTile):
(WebKit::AsyncPDFRenderer::coverageRectDidChange):
(WebKit::AsyncPDFRenderer::removePagePreviewsOutsideCoverageRect):
(WebKit::AsyncPDFRenderer::willRemoveGrid):
(WebKit::AsyncPDFRenderer::clearRequestsAndCachedTiles):
(WebKit::AsyncPDFRenderer::enqueueTileRenderIfNecessary):
(WebKit::AsyncPDFRenderer::serviceRequestQueues):
(WebKit::AsyncPDFRenderer::didCompleteTileRender):
(WebKit::AsyncPDFRenderer::paintPagePreview):
(WebKit::AsyncPDFRenderer::serviceRequestQueue): Deleted.

Canonical link: https://commits.webkit.org/290203@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications