[webkit-changes] [WebKit/WebKit] 301d7e: Move most of TestWebKitAPI.IPCTestingAPI.Serialize...

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 301d7e89fac6c4277ff2304526ddc4622f41d05b
      https://github.com/WebKit/WebKit/commit/301d7e89fac6c4277ff2304526ddc4622f41d05b
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2025-02-10 (Mon, 10 Feb 2025)

  Changed paths:
    A LayoutTests/ipc/serialized-type-info-expected.txt
    A LayoutTests/ipc/serialized-type-info.html
    M Source/WebKit/Platform/IPC/MessageArgumentDescriptions.h
    M Source/WebKit/Scripts/webkit/messages.py
    M Source/WebKit/Scripts/webkit/tests/MessageArgumentDescriptions.cpp
    M Source/WebKit/WebProcess/WebPage/IPCTestingAPI.cpp
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/IPCTestingAPI.mm
    M Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl
    M Tools/WebKitTestRunner/InjectedBundle/TestRunner.h

  Log Message:
  -----------
  Move most of TestWebKitAPI.IPCTestingAPI.SerializedTypeInfo to a layout test
https://bugs.webkit.org/show_bug.cgi?id=287307
rdar://144420258

Reviewed by Chris Dumez.

The API test verifies that all the serialized C++ types have proper type metadata in
*.serialization.in files so the IPC test API can see what they consist of.
It is often broken, and its output isn't as clear as it could be when it fails.
This makes it a layout test so EWS will have some coverage, and it makes the failure
message tell you exactly what types have issues without showing a dictionary of all
the types expected to not have IPC metadata yet.

I also removed some unneeded std::optional and enum metadata from the early days
of IPC investigations.

* LayoutTests/ipc/serialized-type-info-expected.txt: Added.
* LayoutTests/ipc/serialized-type-info.html: Added.
* Source/WebKit/Platform/IPC/MessageArgumentDescriptions.h:
* Source/WebKit/Scripts/webkit/messages.py:
(generate_js_argument_descriptions):
* Source/WebKit/WebProcess/WebPage/IPCTestingAPI.cpp:
(WebKit::IPCTestingAPI::createJSArrayForArgumentDescriptions):
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::frameWasRemovedInAnotherProcess):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/IPCTestingAPI.mm:
(SerializedTypeInfo)):
* Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
* Tools/WebKitTestRunner/InjectedBundle/TestRunner.h:
(WTR::TestRunner::haveSecureCodingRequest const):
(WTR::TestRunner::haveSecureCodingDataDetectors const):

Canonical link: https://commits.webkit.org/290188@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications