[webkit-changes] [WebKit/WebKit] e240c7: REGRESSION(290132 at main): [iOS] TestWebKitAPI.iOSSt...

[mattwoodrow]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e240c702bc2d00fc8ed641aed8bad4de33419ebf
      https://github.com/WebKit/WebKit/commit/e240c702bc2d00fc8ed641aed8bad4de33419ebf
  Author: Matt Woodrow <mattwoodrow at apple.com>
  Date:   2025-02-10 (Mon, 10 Feb 2025)

  Changed paths:
    M Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm

  Log Message:
  -----------
  REGRESSION(290132 at main): [iOS] TestWebKitAPI.iOSStylusSupport.StylusLaterDisconnected (api-tests) are crashing.
https://bugs.webkit.org/show_bug.cgi?id=287414
<rdar://144538441>

Reviewed by Jonathan Bedard.

These assertions were invalid, so removing them.

The old code didn't have an optional for lastVisibleContentRectUpdate, so just
returned the default initializations of the members if read before we actually
got a rect update.

I added the assertions when moving the struct into an optional, expecting this
not to happen, but it clearly does (without any known broken behaviour).
Removing the assertions to explictly return default values restores the old
behaviour.

* Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::displayedContentScale const):
(WebKit::WebPageProxy::exposedContentRect const):
(WebKit::WebPageProxy::unobscuredContentRect const):
(WebKit::WebPageProxy::inStableState const):
(WebKit::WebPageProxy::unobscuredContentRectRespectingInputViewBounds const):
(WebKit::WebPageProxy::layoutViewportRect const):

Canonical link: https://commits.webkit.org/290175@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications