[webkit-changes] [WebKit/WebKit] 91fb05: [scroll-animations] make `animation-timeline`, `an...

[Antoine Quint]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 91fb05af09f927320fd7cf97e17f575056b53443
      https://github.com/WebKit/WebKit/commit/91fb05af09f927320fd7cf97e17f575056b53443
  Author: Antoine Quint <graouts at webkit.org>
  Date:   2025-02-10 (Mon, 10 Feb 2025)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/animation-shorthand-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/animation-shorthand-expected.txt
    M Source/WebCore/css/CSSProperties.json
    M Source/WebCore/css/ComputedStyleExtractor.cpp
    M Source/WebCore/css/ShorthandSerializer.cpp
    M Source/WebCore/css/parser/CSSPropertyParser.cpp

  Log Message:
  -----------
  [scroll-animations] make `animation-timeline`, `animation-range-start` and `animation-range-end` reset-only longhands of the `animation` shorthand
https://bugs.webkit.org/show_bug.cgi?id=287398

Reviewed by Tim Nguyen.

The CSS WG resolved in https://github.com/w3c/csswg-drafts/issues/6946#issuecomment-1233190360 to make the
new CSS properties introduced to support Scroll-driven Animations – `animation-timeline`, `animation-range-start`
and `animation-range-end` – reset-only longhands of the `animation` shorthand.

To that end, we add those properties to the `"longhands"` property for `animation` in `CSSProperties.json`
and deal with them when relevant:

- in `CSSPropertyParser.cpp` we set `nullptr` values for those properties to reset any value previously set
and ensure those properties have the right initial values for serialization purposes.

- in `ComputedStyleExtractor.cpp` we return an empty value whenever we attempt to serialize the `animation`
shorthand in the computed style when one of those reset-only longhands was otherwise set.

- in `ShorthandSerializer.cpp` we do similar work when serializing the specified value.

* LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/animation-shorthand-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/animation-shorthand-expected.txt:
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/ComputedStyleExtractor.cpp:
(WebCore::animationShorthandValue):
* Source/WebCore/css/ShorthandSerializer.cpp:
(WebCore::ShorthandSerializer::serializeLayered const):
* Source/WebCore/css/parser/CSSPropertyParser.cpp:
(WebCore::initialValueForLonghand):
(WebCore::consumeAnimationValueForShorthand):
(WebCore::CSSPropertyParser::consumeAnimationShorthand):

Canonical link: https://commits.webkit.org/290168@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications