[webkit-changes] [WebKit/WebKit] c8b7fe: [Cleanup] Rename visual overflow to ink overflow i...

Alan Baradlay noreply at github.com
Sat Feb 8 05:23:59 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c8b7feed839c9d69ce2c6aeab7c09e6e98ac25cf
      https://github.com/WebKit/WebKit/commit/c8b7feed839c9d69ce2c6aeab7c09e6e98ac25cf
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2025-02-08 (Sat, 08 Feb 2025)

  Changed paths:
    M Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp
    M Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContent.h
    M Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContentBuilder.cpp
    M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp
    M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.h
    M Source/WebCore/rendering/RenderBlockFlow.cpp
    M Source/WebCore/rendering/RenderInline.cpp
    M Source/WebCore/rendering/style/RenderStyle.cpp
    M Source/WebCore/style/InlineTextBoxStyle.cpp
    M Source/WebCore/style/InlineTextBoxStyle.h

  Log Message:
  -----------
  [Cleanup] Rename visual overflow to ink overflow in IFC
https://bugs.webkit.org/show_bug.cgi?id=287254#

Reviewed by Antti Koivisto.

Use CSS spec language wherever possible.

* Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:
(WebCore::Layout::computeInkOverflowForInlineLevelBox):
(WebCore::Layout::computeInkOverflowForInlineBox):
(WebCore::Layout::InlineDisplayContentBuilder::collectInkOverflowForTextDecorations):
* Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContent.h:
(WebCore::LayoutIntegration::InlineContent::hasInkOverflow const):
(WebCore::LayoutIntegration::InlineContent::setHasInkOverflow):
(WebCore::LayoutIntegration::InlineContent::hasVisualOverflow const): Deleted.
(WebCore::LayoutIntegration::InlineContent::setHasVisualOverflow): Deleted.
* Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContentBuilder.cpp:
(WebCore::LayoutIntegration::InlineContentBuilder::adjustDisplayLines const):
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::hasInkOverflow const):
(WebCore::LayoutIntegration::LineLayout::inkOverflowBoundingBoxRectFor const):
(WebCore::LayoutIntegration::LineLayout::hasVisualOverflow const): Deleted.
(WebCore::LayoutIntegration::LineLayout::visualOverflowBoundingBoxRectFor const): Deleted.
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.h:
* Source/WebCore/rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::inlineContentTopAndBottomIncludingInkOverflow const):
* Source/WebCore/rendering/RenderInline.cpp:
(WebCore::RenderInline::linesVisualOverflowBoundingBox const):
* Source/WebCore/rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::changeAffectsVisualOverflow const):
* Source/WebCore/style/InlineTextBoxStyle.cpp:
(WebCore::computedInkOverflowForDecorations):
(WebCore::inkOverflowForDecorations):
(WebCore::computedVisualOverflowForDecorations): Deleted.
(WebCore::visualOverflowForDecorations): Deleted.
* Source/WebCore/style/InlineTextBoxStyle.h:

Canonical link: https://commits.webkit.org/290085@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list