[webkit-changes] [WebKit/WebKit] aadb94: Don't do silent push tracking for declarative push...

[Brady Eidson]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: aadb942b6eaaa6eec0f814d0f165322ba2d6b736
      https://github.com/WebKit/WebKit/commit/aadb942b6eaaa6eec0f814d0f165322ba2d6b736
  Author: Brady Eidson <beidson at apple.com>
  Date:   2025-02-07 (Fri, 07 Feb 2025)

  Changed paths:
    M Source/WebKit/NetworkProcess/NetworkProcess.cpp
    M Source/WebKit/Shared/WebPushDaemonConnectionConfiguration.h
    M Source/WebKit/Shared/WebPushDaemonConnectionConfiguration.serialization.in
    M Source/WebKit/webpushd/PushClientConnection.h
    M Source/WebKit/webpushd/PushClientConnection.mm
    M Source/WebKit/webpushd/WebPushDaemon.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm

  Log Message:
  -----------
  Don't do silent push tracking for declarative push messages
rdar://144288698
https://bugs.webkit.org/show_bug.cgi?id=287296

Reviewed by Ben Nham.

If a pending push message is declarative and the PushClientConnection has declarative push enabled,
do not start the silent push timer.

* Source/WebKit/NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::addWebsiteDataStore):
* Source/WebKit/Shared/WebPushDaemonConnectionConfiguration.h:
* Source/WebKit/Shared/WebPushDaemonConnectionConfiguration.serialization.in:
* Source/WebKit/webpushd/PushClientConnection.h:
(WebPushD::PushClientConnection::declarativeWebPushEnabled const):
* Source/WebKit/webpushd/PushClientConnection.mm:
(WebPushD::PushClientConnection::create):
(WebPushD::PushClientConnection::PushClientConnection):
* Source/WebKit/webpushd/WebPushDaemon.mm:
(WebPushD::WebPushDaemon::getPendingPushMessage):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm:
(TestWebKitAPI::(WebPushDPushNotificationEventTest, Basic)):

Canonical link: https://commits.webkit.org/290070@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications