[webkit-changes] [WebKit/WebKit] 637c4d: Enable -Wunsafe-buffer-usage-in-libc-call

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 637c4dc64e64ad103d707b5192a3b48050efbac6
      https://github.com/WebKit/WebKit/commit/637c4dc64e64ad103d707b5192a3b48050efbac6
  Author: Geoffrey Garen <ggaren at apple.com>
  Date:   2025-02-07 (Fri, 07 Feb 2025)

  Changed paths:
    M Configurations/CommonBase.xcconfig
    M Source/WTF/wtf/Compiler.h
    M Source/WTF/wtf/StdLibExtras.h
    M Source/WebCore/bridge/objc/objc_class.mm
    M Source/WebCore/bridge/objc/objc_utility.mm
    M Source/WebCore/dom/Node.cpp
    M Source/WebCore/editing/VisibleSelection.cpp
    M Source/WebCore/loader/FTPDirectoryParser.cpp
    M Source/WebCore/platform/graphics/cg/UTIRegistry.mm
    M Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp
    M Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm

  Log Message:
  -----------
  Enable -Wunsafe-buffer-usage-in-libc-call
https://bugs.webkit.org/show_bug.cgi?id=287209
rdar://144351483

Reviewed by David Kilzer.

Only very recent compilers enforce this warning.

I built locally with one of them and it seems to pass.

Also fixed up some cases I missed before.

* Configurations/CommonBase.xcconfig: I'm leaving behind some of the .xcconfig
support for disabling this warning for now, just in case.

* Source/WTF/wtf/Compiler.h: Skip the new warning when skipping warnings.

* Source/WTF/wtf/StdLibExtras.h: Put our skip markers inside our macro because
markers around the macro only seem to take effect when defining the macro,
and not when expanding it.

* Configurations/CommonBase.xcconfig: Enable.

Canonical link: https://commits.webkit.org/290060@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications