[webkit-changes] [WebKit/WebKit] 09af7b: `FullscreenManager::updatePageFullscreenStatusIfTo...

[Tim Nguyen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 09af7b0c35cd6a6ecc456d3fd27b20cf95ead4d4
      https://github.com/WebKit/WebKit/commit/09af7b0c35cd6a6ecc456d3fd27b20cf95ead4d4
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2025-02-07 (Fri, 07 Feb 2025)

  Changed paths:
    M Source/WebCore/dom/FullscreenManager.cpp

  Log Message:
  -----------
  `FullscreenManager::updatePageFullscreenStatusIfTopDocument()` should not track `m_fullscreenElement`
https://bugs.webkit.org/show_bug.cgi?id=287272
rdar://144400394

Reviewed by Alex Christensen.

m_fullscreenElement inaccurately represents the fullscreen element in the case where the fullscreen element is implicitly fullscreened
by the children. 288737 at main changed the behavior in that specific case.

Track fullscreenElement() instead, which is linked to the top layer and the fullscreen flag.

* Source/WebCore/dom/FullscreenManager.cpp:
(WebCore::FullscreenManager::exitFullscreen):
(WebCore::FullscreenManager::finishExitFullscreen):
(WebCore::FullscreenManager::willEnterFullscreen):
(WebCore::FullscreenManager::didExitFullscreen):
(WebCore::FullscreenManager::updatePageFullscreenStatusIfTopDocument):
(WebCore::FullscreenManager::clear):

Canonical link: https://commits.webkit.org/290048@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications