[webkit-changes] [WebKit/WebKit] 987704: AX: attributed string for range truncated for list...

[Dominic Mazzoni]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 98770472e072b7648f4324af7867c294e40f8fb0
      https://github.com/WebKit/WebKit/commit/98770472e072b7648f4324af7867c294e40f8fb0
  Author: Dominic Mazzoni <dm_mazzoni at apple.com>
  Date:   2025-02-07 (Fri, 07 Feb 2025)

  Changed paths:
    A LayoutTests/accessibility/mac/line-text-marker-range-in-list-item-expected.txt
    A LayoutTests/accessibility/mac/line-text-marker-range-in-list-item.html
    M Source/WebCore/accessibility/AXCoreObject.h
    M Source/WebCore/accessibility/AXLogger.cpp
    M Source/WebCore/accessibility/AccessibilityObject.cpp
    M Source/WebCore/accessibility/AccessibilityObject.h
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h
    M Source/WebCore/accessibility/isolatedtree/mac/AXIsolatedObjectMac.mm

  Log Message:
  -----------
  AX: attributed string for range truncated for list items
https://bugs.webkit.org/show_bug.cgi?id=287124
rdar://144274917

Reviewed by Tyler Wilcock.

The list item's text node might consist of, say, 10 characters, but
the attributed string for the whole text element includes the list
marker character, resulting in a length of 12 total. But if you fetch
the attributed string for range with a range of (0, 10) you end up
getting the list marker, but the end of the string gets truncated.
The fix is to take the prefix from the list marker into account
when returning the attributed string for a range including the beginning
of the node.

* LayoutTests/accessibility/mac/line-text-marker-range-in-list-item-expected.txt: Added.
* LayoutTests/accessibility/mac/line-text-marker-range-in-list-item.html: Added.
* Source/WebCore/accessibility/AXCoreObject.h:
* Source/WebCore/accessibility/AXLogger.cpp:
(WebCore::operator<<):
* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::textContentPrefixFromListMarker const):
* Source/WebCore/accessibility/AccessibilityObject.h:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::initializeProperties):
(WebCore::AXIsolatedObject::textContentPrefixFromListMarker const):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h:
* Source/WebCore/accessibility/isolatedtree/mac/AXIsolatedObjectMac.mm:
(WebCore::AXIsolatedObject::attributedStringForTextMarkerRange const):

Canonical link: https://commits.webkit.org/290041@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications