[webkit-changes] [WebKit/WebKit] 245598: [Cleanup] Move InlineContent's public data members...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 24559849686de1b618bbe22460ac2a0daedfe3c4
      https://github.com/WebKit/WebKit/commit/24559849686de1b618bbe22460ac2a0daedfe3c4
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2025-02-07 (Fri, 07 Feb 2025)

  Changed paths:
    M Source/WebCore/layout/integration/LayoutIntegrationBoxTreeUpdater.h
    M Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContent.cpp
    M Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContent.h
    M Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContentBuilder.cpp
    M Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContentBuilder.h
    M Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContentPainter.h
    M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp
    M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.h
    M Source/WebCore/layout/integration/inline/LayoutIntegrationPagination.cpp

  Log Message:
  -----------
  [Cleanup] Move InlineContent's public data members to private
https://bugs.webkit.org/show_bug.cgi?id=287252

Reviewed by Antti Koivisto.

InlineContent used to be a very simple struct but turned into a more complex container over time.

* Source/WebCore/layout/integration/LayoutIntegrationBoxTreeUpdater.h:
* Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContent.cpp:
(WebCore::LayoutIntegration::InlineContent::InlineContent):
(WebCore::LayoutIntegration:: const):
(WebCore::LayoutIntegration::InlineContent::formattingContextRoot const):
* Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContent.h:
(WebCore::LayoutIntegration::InlineContent::isPaginated const):
(WebCore::LayoutIntegration::InlineContent::firstLinePaginationOffset const):
(WebCore::LayoutIntegration::InlineContent::clearBeforeAfterGaps const):
(WebCore::LayoutIntegration::InlineContent::clearGapBeforeFirstLine const):
(WebCore::LayoutIntegration::InlineContent::lineForBox const):
(WebCore::LayoutIntegration::InlineContent::setHasVisualOverflow):
(WebCore::LayoutIntegration::InlineContent::setHasMultilinePaintOverlap):
(WebCore::LayoutIntegration::InlineContent::setClearGapBeforeFirstLine):
(WebCore::LayoutIntegration::InlineContent::setClearGapAfterLastLine):
(WebCore::LayoutIntegration::InlineContent::setFirstLinePaginationOffset):
(WebCore::LayoutIntegration::InlineContent::lineLayout const): Deleted.
* Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContentBuilder.cpp:
(WebCore::LayoutIntegration::InlineContentBuilder::adjustDisplayLines const):
* Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContentBuilder.h:
* Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContentPainter.h:
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::constructContent):
(WebCore::LayoutIntegration::LineLayout::isPaginated const):
(WebCore::LayoutIntegration::LineLayout::clampedContentLogicalHeight const):
(WebCore::LayoutIntegration::LineLayout::contentLogicalHeight const):
(WebCore::LayoutIntegration::LineLayout::adjustContentForPagination):
(WebCore::LayoutIntegration::LineLayout::ensureInlineContent):
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.h:
* Source/WebCore/layout/integration/inline/LayoutIntegrationPagination.cpp:
(WebCore::LayoutIntegration::computeAdjustmentsForPagination):
(WebCore::LayoutIntegration::adjustLinePositionsForPagination):

Canonical link: https://commits.webkit.org/290039@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications