[webkit-changes] [WebKit/WebKit] bda8d9: BBQJIT::addArrayGet needs to consume index when th...

[Keith Miller]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bda8d91633ad360c8cb949ff20e19c1276f80a5d
      https://github.com/WebKit/WebKit/commit/bda8d91633ad360c8cb949ff20e19c1276f80a5d
  Author: Keith Miller <keith_miller at apple.com>
  Date:   2025-02-07 (Fri, 07 Feb 2025)

  Changed paths:
    M Source/JavaScriptCore/wasm/WasmBBQJIT64.cpp
    M Source/JavaScriptCore/wasm/WasmFunctionParser.h
    M Source/JavaScriptCore/wasm/WasmParser.h
    M Source/JavaScriptCore/wasm/generateWasmOpsHeader.py

  Log Message:
  -----------
  BBQJIT::addArrayGet needs to consume index when the array is null.
https://bugs.webkit.org/show_bug.cgi?id=287255
rdar://144389091

Reviewed by Yusuke Suzuki.

It breaks our validation when we don't and the case where it's provably null is basically non-existant anyway.

Also, FunctionParser verbose printing should log the extension opcode its about to handle.

* Source/JavaScriptCore/wasm/WasmBBQJIT64.cpp:
(JSC::Wasm::BBQJITImpl::BBQJIT::addArrayGet):
* Source/JavaScriptCore/wasm/WasmFunctionParser.h:
(JSC::Wasm::FunctionParser<Context>::parseBody):
* Source/JavaScriptCore/wasm/WasmParser.h:
(JSC::Wasm::ParserBase::peekVarUInt32):
* Source/JavaScriptCore/wasm/generateWasmOpsHeader.py:

Canonical link: https://commits.webkit.org/290022@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications