[webkit-changes] [WebKit/WebKit] bafa3f: [GStreamer] Refactor away MediaPlayerPrivateGStrea...

[Alicia Boya García]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bafa3f6bc15fbff68d28591802ba0d5ffcdac5d9
      https://github.com/WebKit/WebKit/commit/bafa3f6bc15fbff68d28591802ba0d5ffcdac5d9
  Author: Alicia Boya Garcia <aboya at igalia.com>
  Date:   2025-02-07 (Fri, 07 Feb 2025)

  Changed paths:
    M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
    M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h
    M Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp

  Log Message:
  -----------
  [GStreamer] Refactor away MediaPlayerPrivateGStreamer::m_isPausedByViewport
https://bugs.webkit.org/show_bug.cgi?id=287162

Reviewed by Philippe Normand.

This is a follow-up of the cleanups discussed in
https://github.com/WebKit/WebKit/pull/39765.

This patch combines m_isPausedByViewport and m_invisiblePlayerState into
one single field and renames it to m_stateToRestoreWhenVisible. The
field is set to VOID_PENDING when we're not paused by viewport.

Additionally, safeguards have been added to setVisibleInViewport() to
prevent the suspension code from accidentally running more than once.

* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::changePipelineState):
(WebCore::MediaPlayerPrivateGStreamer::setVisibleInViewport):
(WebCore::MediaPlayerPrivateGStreamer::paint):
* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
(WebCore::MediaPlayerPrivateGStreamer::isPausedByViewport):
* Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:
(WebCore::MediaPlayerPrivateGStreamerMSE::updateStates):

Canonical link: https://commits.webkit.org/289997@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications