[webkit-changes] [WebKit/WebKit] cba51d: Implement fullscreen rendering update step

[Tim Nguyen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cba51d14a79420eea435792f37f3e379bc523bb9
      https://github.com/WebKit/WebKit/commit/cba51d14a79420eea435792f37f3e379bc523bb9
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2025-02-06 (Thu, 06 Feb 2025)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/imported/w3c/web-platform-tests/fullscreen/api/element-ready-allowed-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/fullscreen/api/element-request-fullscreen-and-move-to-iframe-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/fullscreen/api/element-request-fullscreen-namespaces-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/fullscreen/api/element-request-fullscreen-svg-rect-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/fullscreen/model/move-to-iframe-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/fullscreen/model/move-to-inactive-document-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/fullscreen/model/remove-first-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/fullscreen/model/remove-last-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/fullscreen/model/remove-parent-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/fullscreen/rendering/fullscreen-pseudo-class-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/fullscreen/rendering/fullscreen-root-block-scroll-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/fullscreen/rendering/fullscreen-root-block-size-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/fullscreen/rendering/ua-style-iframe-expected.txt
    A LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/fullscreen/api/element-request-fullscreen-and-move-to-iframe-expected.txt
    R LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/fullscreen/api/element-request-fullscreen-timing-expected.txt
    M Source/WebCore/dom/FullscreenManager.cpp
    M Source/WebCore/dom/FullscreenManager.h
    M Source/WebCore/page/Page.cpp
    M Source/WebCore/page/Quirks.cpp
    M Source/WebCore/page/Quirks.h
    M Source/WebCore/page/QuirksData.h

  Log Message:
  -----------
  Implement fullscreen rendering update step
https://bugs.webkit.org/show_bug.cgi?id=249069
rdar://103209495

Reviewed by Alex Christensen.

Event dispatching should be done by the rendering update steps.

https://html.spec.whatwg.org/multipage/webappapis.html#update-the-rendering
https://fullscreen.spec.whatwg.org/#run-the-fullscreen-steps

* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/web-platform-tests/fullscreen/api/element-ready-allowed-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/fullscreen/api/element-request-fullscreen-namespaces-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/fullscreen/model/move-to-iframe-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/fullscreen/model/move-to-inactive-document-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/fullscreen/rendering/fullscreen-pseudo-class-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/fullscreen/rendering/fullscreen-root-block-scroll-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/fullscreen/rendering/fullscreen-root-block-size-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/fullscreen/rendering/ua-style-iframe-expected.txt:
* LayoutTests/platform/mac-wk1/TestExpectations:
* LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/fullscreen/api/element-request-fullscreen-and-move-to-iframe-expected.txt: Added.
* LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/fullscreen/api/element-request-fullscreen-timing-expected.txt: Removed.
* Source/WebCore/dom/FullscreenManager.cpp:
(WebCore::FullscreenManager::requestFullscreenForElement):
(WebCore::FullscreenManager::willEnterFullscreen):
(WebCore::FullscreenManager::didExitFullscreen):
(WebCore::FullscreenManager::resolvePendingPromise):
(WebCore::FullscreenManager::rejectPendingPromise):
(WebCore::FullscreenManager::dispatchPendingEvents):
(WebCore::FullscreenManager::notifyAboutFullscreenChangeOrError): Deleted.
* Source/WebCore/dom/FullscreenManager.h:
* Source/WebCore/page/Page.cpp:
(WebCore::Page::updateRendering):
* Source/WebCore/page/Quirks.cpp:
(WebCore::handleBBCQuirks):
(WebCore::Quirks::shouldDelayFullscreenEventWhenExitingPictureInPictureQuirk const): Deleted.
* Source/WebCore/page/Quirks.h:
* Source/WebCore/page/QuirksData.h:

Canonical link: https://commits.webkit.org/289984@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications