[webkit-changes] [WebKit/WebKit] 5c5eac: Fix multi-column layout in sideways-lr writing mode

[Tim Nguyen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5c5eacfa2fae910834716d98bacecf16c8178def
      https://github.com/WebKit/WebKit/commit/5c5eacfa2fae910834716d98bacecf16c8178def
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2025-02-06 (Thu, 06 Feb 2025)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/imported/w3c/web-platform-tests/css/css-multicol/getclientrects-001-expected.txt
    M Source/WebCore/rendering/RenderMultiColumnSet.cpp

  Log Message:
  -----------
  Fix multi-column layout in sideways-lr writing mode
https://bugs.webkit.org/show_bug.cgi?id=287143
rdar://144307524

Reviewed by Alan Baradlay.

We were previously only drawing one column in sideways-lr writing mode.

Update `isBidiLTR()` checks to instead use `isLogicalLeftInlineStart()` since the text direction isn't
what matters in this context.

Rebaseline WPTs added by Chromium: https://github.com/chromium/chromium/commit/81c84c0838e3b3d868d38fc202c06a6c0fc8d5ab

* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/web-platform-tests/css/css-multicol/getclientrects-001-expected.txt:
* Source/WebCore/rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::columnLogicalLeft const):
(WebCore::RenderMultiColumnSet::fragmentedFlowPortionOverflowRect const):
(WebCore::RenderMultiColumnSet::paintColumnRules):
(WebCore::RenderMultiColumnSet::collectLayerFragments):

Canonical link: https://commits.webkit.org/289947@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications