[webkit-changes] [WebKit/WebKit] 2a3710: [visionOS] Remove the AlternateFormControlDesignEn...

[Aditya Keerthi]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2a37102734b97c48ae66f3413a38f56f064849d2
      https://github.com/WebKit/WebKit/commit/2a37102734b97c48ae66f3413a38f56f064849d2
  Author: Aditya Keerthi <akeerthi at apple.com>
  Date:   2025-02-05 (Wed, 05 Feb 2025)

  Changed paths:
    M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
    M Source/WebCore/rendering/ios/RenderThemeIOS.h
    M Source/WebCore/rendering/ios/RenderThemeIOS.mm
    M Source/WebKit/Shared/WebPreferencesDefaultValues.cpp
    M Source/WebKit/Shared/WebPreferencesDefaultValues.h
    M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
    M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm

  Log Message:
  -----------
  [visionOS] Remove the AlternateFormControlDesignEnabled preference
https://bugs.webkit.org/show_bug.cgi?id=278217
rdar://134547193

Reviewed by Tim Horton, Abrar Rahman Protyasha, and Megan Gardner.

AlternateFormControlDesignEnabled is always enabled when running WebKit with
the visionOS idiom, and refers solely to the visionOS form control design.

Remove it and replace with idiom checks to avoid any confusion.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/rendering/ios/RenderThemeIOS.h:
* Source/WebCore/rendering/ios/RenderThemeIOS.mm:
(WebCore::RenderThemeIOS::adjustTextFieldStyle const):
(WebCore::RenderThemeIOS::paintTextFieldDecorations):
(WebCore::RenderThemeIOS::adjustTextAreaStyle const):
(WebCore::RenderThemeIOS::adjustButtonLikeControlStyle const):

Remove the FIXME, as the current design has shipped for a while and is the
de facto design.

(WebCore::RenderThemeIOS::checkboxRadioBackgroundColor):

Remove the FIXME, the internal bug is closed.

(WebCore::RenderThemeIOS::paintCheckbox):
(WebCore::RenderThemeIOS::paintRadio):
* Source/WebKit/Shared/WebPreferencesDefaultValues.cpp:
(WebKit::defaultAlternateFormControlDesignEnabled): Deleted.
* Source/WebKit/Shared/WebPreferencesDefaultValues.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _setupPageConfiguration:withPool:]):
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView formAccessoryView]):

Canonical link: https://commits.webkit.org/289901@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications