[webkit-changes] [WebKit/WebKit] e98093: Make Document::isTopDocument and Document::mainFra...

Alex Christensen noreply at github.com
Wed Feb 5 14:47:10 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e9809384e1a5946a476f6b296294d4ef42cdd735
      https://github.com/WebKit/WebKit/commit/e9809384e1a5946a476f6b296294d4ef42cdd735
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2025-02-05 (Wed, 05 Feb 2025)

  Changed paths:
    M Source/WebCore/dom/Document.cpp
    M Source/WebCore/dom/Document.h
    M Source/WebCore/html/MediaElementSession.cpp

  Log Message:
  -----------
  Make Document::isTopDocument and Document::mainFrameDocument consistent, take 2
https://bugs.webkit.org/show_bug.cgi?id=287118
rdar://144261558

Reviewed by Brady Eidson.

This was originally done in 289267 at main but it was reverted because a dependent change
was reverted.  Now that 289891 at main is back in, this can go back in.

This correctness makes it so Document::setInTouchEventHandling is no longer infinite
recursion on iOS when tapping an iframe.

* Source/WebCore/dom/Document.cpp:
(WebCore::Document::mainFrameDocument const):
(WebCore::Document::isTopDocument const): Deleted.
* Source/WebCore/dom/Document.h:
(WebCore::Document::isTopDocument const):
(WebCore::Document::isTopDocumentLegacy const): Deleted.
* Source/WebCore/html/MediaElementSession.cpp:
(WebCore::MediaElementSession::playbackStateChangePermitted const):

Canonical link: https://commits.webkit.org/289894@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list