[webkit-changes] [WebKit/WebKit] 0bfd0b: Common types used across [Platform]MouseEvent.h sh...

[Abrar Rahman Protyasha]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0bfd0b0c2c3be61710f849f4d63f510f29b0a9b1
      https://github.com/WebKit/WebKit/commit/0bfd0b0c2c3be61710f849f4d63f510f29b0a9b1
  Author: Abrar Rahman Protyasha <a_protyasha at apple.com>
  Date:   2025-02-05 (Wed, 05 Feb 2025)

  Changed paths:
    M Source/WebCore/Headers.cmake
    M Source/WebCore/Modules/model-element/HTMLModelElement.cpp
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/dom/MouseEvent.h
    A Source/WebCore/dom/MouseEventTypes.h
    M Source/WebCore/dom/Node.cpp
    M Source/WebCore/dom/PointerEvent.cpp
    M Source/WebCore/dom/SimulatedClick.cpp
    M Source/WebCore/dom/WheelEvent.cpp
    M Source/WebCore/dom/ios/MouseEventIOS.cpp
    M Source/WebCore/dom/ios/PointerEventIOS.cpp
    M Source/WebCore/html/HTMLAnchorElement.cpp
    M Source/WebCore/html/HTMLInputElement.cpp
    M Source/WebCore/html/HTMLSelectElement.cpp
    M Source/WebCore/html/shadow/TextControlInnerElements.cpp
    M Source/WebCore/page/AutoscrollController.cpp
    M Source/WebCore/page/PointerCaptureController.cpp
    M Source/WebCore/page/PointerCaptureController.h
    M Source/WebCore/page/ios/EventHandlerIOS.mm
    M Source/WebCore/page/mac/ServicesOverlayController.mm
    M Source/WebCore/platform/PlatformMouseEvent.h
    M Source/WebCore/platform/ios/PlatformEventFactoryIOS.mm
    M Source/WebCore/platform/mac/PlatformEventFactoryMac.mm
    M Source/WebCore/rendering/RenderEmbeddedObject.cpp
    M Source/WebKit/Shared/API/c/WKSharedAPICast.h
    M Source/WebKit/Shared/WebEventConversion.cpp
    M Source/WebKit/Shared/WebMouseEvent.cpp
    M Source/WebKit/WebProcess/WebPage/WebFrame.cpp
    M Source/WebKitLegacy/ios/WebView/WebPDFViewPlaceholder.mm
    M Source/WebKitLegacy/mac/WebView/WebFrame.mm
    M Source/WebKitLegacy/mac/WebView/WebPDFView.mm
    M Tools/DumpRenderTree/mac/EventSendingController.mm
    M Tools/TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm
    M Tools/WebKitTestRunner/mac/EventSenderProxy.mm

  Log Message:
  -----------
  Common types used across [Platform]MouseEvent.h should be declared in a standalone header
https://bugs.webkit.org/show_bug.cgi?id=287059
rdar://144204277

Reviewed by Wenson Hsieh and Aditya Keerthi.

There are some common types/constants used across [Platform]MouseEvent.h
that often need to be referenced throughout the codebase in other
projects (WebKit/WKTR/TestWebKitAPI/etc.), and having these types be
defined across the event headers makes for quite heavy include costs.
For example, pulling in WebCore/MouseEvent.h from DumpRenderTree also
necessitates the inclusion of WebCore/Node.h.

This patch splits out some of these common types/constants into a
separate header, namely MouseEventTypes.h. It also introduces a helper
function WebCore::buttonFromShort(), that will be used from some test
harness code in a forthcoming patch.

* Source/WebCore/Headers.cmake:
* Source/WebCore/Modules/model-element/HTMLModelElement.cpp:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/dom/MouseEvent.h:
* Source/WebCore/dom/MouseEventTypes.h: Added.
(WebCore::buttonFromShort):
* Source/WebCore/dom/Node.cpp:
* Source/WebCore/dom/PointerEvent.cpp:
* Source/WebCore/dom/SimulatedClick.cpp:
* Source/WebCore/dom/WheelEvent.cpp:
* Source/WebCore/dom/ios/MouseEventIOS.cpp:
* Source/WebCore/dom/ios/PointerEventIOS.cpp:
* Source/WebCore/html/HTMLAnchorElement.cpp:
* Source/WebCore/html/HTMLInputElement.cpp:
* Source/WebCore/html/HTMLSelectElement.cpp:
* Source/WebCore/html/shadow/TextControlInnerElements.cpp:
* Source/WebCore/page/AutoscrollController.cpp:
* Source/WebCore/page/PointerCaptureController.cpp:
* Source/WebCore/page/PointerCaptureController.h:
* Source/WebCore/page/ios/EventHandlerIOS.mm:
* Source/WebCore/page/mac/ServicesOverlayController.mm:
* Source/WebCore/platform/PlatformMouseEvent.h:
* Source/WebCore/platform/ios/PlatformEventFactoryIOS.mm:
* Source/WebCore/platform/mac/PlatformEventFactoryMac.mm:
* Source/WebCore/rendering/RenderEmbeddedObject.cpp:
* Source/WebKit/Shared/API/c/WKSharedAPICast.h:
* Source/WebKit/Shared/WebEventConversion.cpp:
* Source/WebKit/Shared/WebMouseEvent.cpp:
* Source/WebKit/WebProcess/WebPage/WebFrame.cpp:
* Source/WebKitLegacy/ios/WebView/WebPDFViewPlaceholder.mm:
* Source/WebKitLegacy/mac/WebView/WebFrame.mm:
* Source/WebKitLegacy/mac/WebView/WebPDFView.mm:
* Tools/DumpRenderTree/mac/EventSendingController.mm:
* Tools/TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
* Tools/WebKitTestRunner/mac/EventSenderProxy.mm:

Canonical link: https://commits.webkit.org/289859@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications