[webkit-changes] [WebKit/WebKit] 070fb7: Web Inspector: remove WebDatabase support from bac...

Blaze Jayne noreply at github.com
Tue Feb 4 21:42:10 PST 2025 

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 070fb7ec99ba0ba82848fa2c248646e4bd728ea6
      https://github.com/WebKit/WebKit/commit/070fb7ec99ba0ba82848fa2c248646e4bd728ea6
  Author: BJ Burg <bburg at apple.com>
  Date:   2025-02-04 (Tue, 04 Feb 2025)

  Changed paths:
    M LayoutTests/inspector/runtime/CommandLineAPI-inspect.html
    M Source/JavaScriptCore/CMakeLists.txt
    M Source/JavaScriptCore/DerivedSources-input.xcfilelist
    M Source/JavaScriptCore/DerivedSources.make
    R Source/JavaScriptCore/inspector/protocol/Database.json
    M Source/WebCore/Modules/webdatabase/DatabaseManager.cpp
    M Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
    M Source/WebCore/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations
    M Source/WebCore/Sources.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/inspector/CommandLineAPIHost.cpp
    M Source/WebCore/inspector/CommandLineAPIHost.h
    M Source/WebCore/inspector/CommandLineAPIHost.idl
    M Source/WebCore/inspector/InspectorController.cpp
    R Source/WebCore/inspector/InspectorDatabaseResource.cpp
    R Source/WebCore/inspector/InspectorDatabaseResource.h
    M Source/WebCore/inspector/InspectorInstrumentation.cpp
    M Source/WebCore/inspector/InspectorInstrumentation.h
    M Source/WebCore/inspector/InstrumentingAgents.h
    R Source/WebCore/inspector/agents/InspectorDatabaseAgent.cpp
    R Source/WebCore/inspector/agents/InspectorDatabaseAgent.h
    M Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
    M Source/WebInspectorUI/UserInterface/Base/Main.js
    R Source/WebInspectorUI/UserInterface/Controllers/DatabaseManager.js
    M Source/WebInspectorUI/UserInterface/Main.html
    R Source/WebInspectorUI/UserInterface/Models/DatabaseObject.js
    R Source/WebInspectorUI/UserInterface/Models/DatabaseTableObject.js
    M Source/WebInspectorUI/UserInterface/Models/NativeFunctionParameters.js
    R Source/WebInspectorUI/UserInterface/Protocol/DatabaseObserver.js
    M Source/WebInspectorUI/UserInterface/Protocol/InspectorObserver.js
    M Source/WebInspectorUI/UserInterface/Protocol/Legacy/iOS/12.0/InspectorBackendCommands.js
    M Source/WebInspectorUI/UserInterface/Protocol/Legacy/iOS/12.2/InspectorBackendCommands.js
    M Source/WebInspectorUI/UserInterface/Protocol/Legacy/iOS/13.0/InspectorBackendCommands.js
    M Source/WebInspectorUI/UserInterface/Protocol/Legacy/iOS/13.4/InspectorBackendCommands.js
    M Source/WebInspectorUI/UserInterface/Protocol/Legacy/iOS/14.0/InspectorBackendCommands.js
    M Source/WebInspectorUI/UserInterface/Protocol/Legacy/iOS/14.5/InspectorBackendCommands.js
    M Source/WebInspectorUI/UserInterface/Protocol/Legacy/iOS/15.0/InspectorBackendCommands.js
    M Source/WebInspectorUI/UserInterface/Protocol/Legacy/iOS/15.4/InspectorBackendCommands.js
    M Source/WebInspectorUI/UserInterface/Protocol/Legacy/iOS/16.0/InspectorBackendCommands.js
    M Source/WebInspectorUI/UserInterface/Protocol/Legacy/iOS/16.4/InspectorBackendCommands.js
    M Source/WebInspectorUI/UserInterface/Protocol/Legacy/iOS/17.0/InspectorBackendCommands.js
    M Source/WebInspectorUI/UserInterface/Protocol/Legacy/iOS/17.2/InspectorBackendCommands.js
    M Source/WebInspectorUI/UserInterface/Protocol/Legacy/iOS/17.4/InspectorBackendCommands.js
    M Source/WebInspectorUI/UserInterface/Protocol/Legacy/iOS/18.0/InspectorBackendCommands.js
    M Source/WebInspectorUI/UserInterface/Protocol/Legacy/iOS/18.2/InspectorBackendCommands.js
    M Source/WebInspectorUI/UserInterface/Protocol/Legacy/macOS/12.0/InspectorBackendCommands.js
    M Source/WebInspectorUI/UserInterface/Protocol/Legacy/macOS/12.3/InspectorBackendCommands.js
    M Source/WebInspectorUI/UserInterface/Protocol/Legacy/macOS/13.0/InspectorBackendCommands.js
    M Source/WebInspectorUI/UserInterface/Protocol/Legacy/macOS/13.3/InspectorBackendCommands.js
    M Source/WebInspectorUI/UserInterface/Protocol/Legacy/macOS/14.0/InspectorBackendCommands.js
    M Source/WebInspectorUI/UserInterface/Protocol/Legacy/macOS/14.2/InspectorBackendCommands.js
    M Source/WebInspectorUI/UserInterface/Protocol/Legacy/macOS/14.4/InspectorBackendCommands.js
    M Source/WebInspectorUI/UserInterface/Protocol/Legacy/macOS/15.0/InspectorBackendCommands.js
    M Source/WebInspectorUI/UserInterface/Protocol/Legacy/macOS/15.2/InspectorBackendCommands.js
    M Source/WebInspectorUI/UserInterface/Protocol/Target.js
    M Source/WebInspectorUI/UserInterface/Test.html
    M Source/WebInspectorUI/UserInterface/Test/Test.js
    M Source/WebInspectorUI/UserInterface/Views/ContentView.js
    R Source/WebInspectorUI/UserInterface/Views/DatabaseContentView.css
    R Source/WebInspectorUI/UserInterface/Views/DatabaseContentView.js
    R Source/WebInspectorUI/UserInterface/Views/DatabaseHostTreeElement.js
    R Source/WebInspectorUI/UserInterface/Views/DatabaseTableContentView.css
    R Source/WebInspectorUI/UserInterface/Views/DatabaseTableContentView.js
    R Source/WebInspectorUI/UserInterface/Views/DatabaseTableTreeElement.js
    R Source/WebInspectorUI/UserInterface/Views/DatabaseTreeElement.js
    R Source/WebInspectorUI/UserInterface/Views/DatabaseUserQueryErrorView.js
    R Source/WebInspectorUI/UserInterface/Views/DatabaseUserQuerySuccessView.js
    R Source/WebInspectorUI/UserInterface/Views/DatabaseUserQueryViewBase.js
    M Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js
    M Source/WebInspectorUI/UserInterface/Views/StorageSidebarPanel.js
    M Source/WebInspectorUI/UserInterface/Views/StorageTabContentView.js
    M Source/WebInspectorUI/Versions/Inspector-iOS-12.2.json
    M Source/WebInspectorUI/Versions/Inspector-iOS-13.0.json
    M Source/WebInspectorUI/Versions/Inspector-iOS-13.4.json
    M Source/WebInspectorUI/Versions/Inspector-iOS-14.0.json
    M Source/WebInspectorUI/Versions/Inspector-iOS-14.5.json
    M Source/WebInspectorUI/Versions/Inspector-iOS-15.0.json
    M Source/WebInspectorUI/Versions/Inspector-iOS-15.4.json
    M Source/WebInspectorUI/Versions/Inspector-iOS-16.0.json
    M Source/WebInspectorUI/Versions/Inspector-iOS-16.4.json
    M Source/WebInspectorUI/Versions/Inspector-iOS-17.0.json
    M Source/WebInspectorUI/Versions/Inspector-iOS-17.2.json
    M Source/WebInspectorUI/Versions/Inspector-iOS-17.4.json
    M Source/WebInspectorUI/Versions/Inspector-iOS-18.0.json
    M Source/WebInspectorUI/Versions/Inspector-iOS-18.2.json
    M Source/WebInspectorUI/Versions/Inspector-macOS-12.0.json
    M Source/WebInspectorUI/Versions/Inspector-macOS-12.3.json
    M Source/WebInspectorUI/Versions/Inspector-macOS-13.0.json
    M Source/WebInspectorUI/Versions/Inspector-macOS-13.3.json
    M Source/WebInspectorUI/Versions/Inspector-macOS-14.0.json
    M Source/WebInspectorUI/Versions/Inspector-macOS-14.2.json
    M Source/WebInspectorUI/Versions/Inspector-macOS-14.4.json
    M Source/WebInspectorUI/Versions/Inspector-macOS-15.0.json
    M Source/WebInspectorUI/Versions/Inspector-macOS-15.2.json

  Log Message:
  -----------
  Web Inspector: remove WebDatabase support from backend and frontend
rdar://143596276
https://bugs.webkit.org/show_bug.cgi?id=286634

Reviewed by Devin Rousso.

WebSQL has not shipped in several years. In preparation for its full removal
from WebKit, start by ripping out the related code in Web Inspector.

This domain never had any layout tests associated with it, so there are no deleted tests.

* LayoutTests/inspector/runtime/CommandLineAPI-inspect.html:
* Source/JavaScriptCore/CMakeLists.txt:
* Source/JavaScriptCore/DerivedSources-input.xcfilelist:
* Source/JavaScriptCore/DerivedSources.make:
* Source/JavaScriptCore/inspector/protocol/Database.json: Removed.
* Source/WebCore/Modules/webdatabase/DatabaseManager.cpp:
(WebCore::DatabaseManager::openDatabase):
* Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations:
* Source/WebCore/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/inspector/CommandLineAPIHost.cpp:
(WebCore::CommandLineAPIHost::databaseId): Deleted.
* Source/WebCore/inspector/CommandLineAPIHost.h:
* Source/WebCore/inspector/CommandLineAPIHost.idl:
* Source/WebCore/inspector/InspectorController.cpp:
(WebCore::InspectorController::createLazyAgents):
* Source/WebCore/inspector/InspectorDatabaseResource.cpp: Removed.
* Source/WebCore/inspector/InspectorDatabaseResource.h: Removed.
* Source/WebCore/inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didCommitLoadImpl):
(WebCore::InspectorInstrumentation::didOpenDatabaseImpl): Deleted.
* Source/WebCore/inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::didOpenDatabase): Deleted.
* Source/WebCore/inspector/InstrumentingAgents.h:
* Source/WebCore/inspector/agents/InspectorDatabaseAgent.cpp: Removed.
* Source/WebCore/inspector/agents/InspectorDatabaseAgent.h: Removed.
* Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:
* Source/WebInspectorUI/UserInterface/Base/Main.js:
(WI.loaded):
* Source/WebInspectorUI/UserInterface/Controllers/DatabaseManager.js: Removed.
* Source/WebInspectorUI/UserInterface/Main.html:
* Source/WebInspectorUI/UserInterface/Models/DatabaseObject.js: Removed.
* Source/WebInspectorUI/UserInterface/Models/DatabaseTableObject.js: Removed.
* Source/WebInspectorUI/UserInterface/Models/NativeFunctionParameters.js:
* Source/WebInspectorUI/UserInterface/Protocol/DatabaseObserver.js: Removed.
* Source/WebInspectorUI/UserInterface/Protocol/InspectorObserver.js:
(WI.InspectorObserver.prototype.inspect):
* Source/WebInspectorUI/UserInterface/Protocol/Legacy/iOS/12.0/InspectorBackendCommands.js:
* Source/WebInspectorUI/UserInterface/Protocol/Legacy/iOS/12.2/InspectorBackendCommands.js:
* Source/WebInspectorUI/UserInterface/Protocol/Legacy/iOS/13.0/InspectorBackendCommands.js:
* Source/WebInspectorUI/UserInterface/Protocol/Legacy/iOS/13.4/InspectorBackendCommands.js:
* Source/WebInspectorUI/UserInterface/Protocol/Legacy/iOS/14.0/InspectorBackendCommands.js:
* Source/WebInspectorUI/UserInterface/Protocol/Legacy/iOS/14.5/InspectorBackendCommands.js:
* Source/WebInspectorUI/UserInterface/Protocol/Legacy/iOS/15.0/InspectorBackendCommands.js:
* Source/WebInspectorUI/UserInterface/Protocol/Legacy/iOS/15.4/InspectorBackendCommands.js:
* Source/WebInspectorUI/UserInterface/Protocol/Legacy/iOS/16.0/InspectorBackendCommands.js:
* Source/WebInspectorUI/UserInterface/Protocol/Legacy/iOS/16.4/InspectorBackendCommands.js:
* Source/WebInspectorUI/UserInterface/Protocol/Legacy/iOS/17.0/InspectorBackendCommands.js:
* Source/WebInspectorUI/UserInterface/Protocol/Legacy/iOS/17.2/InspectorBackendCommands.js:
* Source/WebInspectorUI/UserInterface/Protocol/Legacy/iOS/17.4/InspectorBackendCommands.js:
* Source/WebInspectorUI/UserInterface/Protocol/Legacy/iOS/18.0/InspectorBackendCommands.js:
* Source/WebInspectorUI/UserInterface/Protocol/Legacy/iOS/18.2/InspectorBackendCommands.js:
* Source/WebInspectorUI/UserInterface/Protocol/Legacy/macOS/12.0/InspectorBackendCommands.js:
* Source/WebInspectorUI/UserInterface/Protocol/Legacy/macOS/12.3/InspectorBackendCommands.js:
* Source/WebInspectorUI/UserInterface/Protocol/Legacy/macOS/13.0/InspectorBackendCommands.js:
* Source/WebInspectorUI/UserInterface/Protocol/Legacy/macOS/13.3/InspectorBackendCommands.js:
* Source/WebInspectorUI/UserInterface/Protocol/Legacy/macOS/14.0/InspectorBackendCommands.js:
* Source/WebInspectorUI/UserInterface/Protocol/Legacy/macOS/14.2/InspectorBackendCommands.js:
* Source/WebInspectorUI/UserInterface/Protocol/Legacy/macOS/14.4/InspectorBackendCommands.js:
* Source/WebInspectorUI/UserInterface/Protocol/Legacy/macOS/15.0/InspectorBackendCommands.js:
* Source/WebInspectorUI/UserInterface/Protocol/Legacy/macOS/15.2/InspectorBackendCommands.js:
* Source/WebInspectorUI/UserInterface/Protocol/Target.js:
(WI.Target.prototype.get DOMStorageAgent):
(WI.Target.prototype.get DatabaseAgent): Deleted.
* Source/WebInspectorUI/UserInterface/Test.html:
* Source/WebInspectorUI/UserInterface/Test/Test.js:
(WI.loaded):
(WI.contentLoaded):
* Source/WebInspectorUI/UserInterface/Views/ContentView.js:
(WI.ContentView.createFromRepresentedObject):
(WI.ContentView.isViewable):
* Source/WebInspectorUI/UserInterface/Views/DatabaseContentView.css: Removed.
* Source/WebInspectorUI/UserInterface/Views/DatabaseContentView.js: Removed.
* Source/WebInspectorUI/UserInterface/Views/DatabaseHostTreeElement.js: Removed.
* Source/WebInspectorUI/UserInterface/Views/DatabaseTableContentView.css: Removed.
* Source/WebInspectorUI/UserInterface/Views/DatabaseTableContentView.js: Removed.
* Source/WebInspectorUI/UserInterface/Views/DatabaseTableTreeElement.js: Removed.
* Source/WebInspectorUI/UserInterface/Views/DatabaseTreeElement.js: Removed.
* Source/WebInspectorUI/UserInterface/Views/DatabaseUserQueryErrorView.js: Removed.
* Source/WebInspectorUI/UserInterface/Views/DatabaseUserQuerySuccessView.js: Removed.
* Source/WebInspectorUI/UserInterface/Views/DatabaseUserQueryViewBase.js: Removed.
* Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js:
(WI.NavigationSidebarPanel.prototype._isTreeElementWithoutRepresentedObject):
* Source/WebInspectorUI/UserInterface/Views/StorageSidebarPanel.js:
(WI.StorageSidebarPanel):
(WI.StorageSidebarPanel.prototype.closed):
(WI.StorageSidebarPanel._treeSelectionDidChange):
(WI.StorageSidebarPanel.prototype._databaseWasAdded): Deleted.
(WI.StorageSidebarPanel.prototype._addDatabase): Deleted.
(WI.StorageSidebarPanel.prototype._databaseWasInspected): Deleted.
(WI.StorageSidebarPanel.prototype._databaseCleared): Deleted.
* Source/WebInspectorUI/UserInterface/Views/StorageTabContentView.js:
(WI.StorageTabContentView):
(WI.StorageTabContentView.isTabAllowed):
(WI.StorageTabContentView.prototype.canShowRepresentedObject):
(WI.StorageTabContentView.prototype.closed):
* Source/WebInspectorUI/Versions/Inspector-iOS-12.2.json:
* Source/WebInspectorUI/Versions/Inspector-iOS-13.0.json:
* Source/WebInspectorUI/Versions/Inspector-iOS-13.4.json:
* Source/WebInspectorUI/Versions/Inspector-iOS-14.0.json:
* Source/WebInspectorUI/Versions/Inspector-iOS-14.5.json:
* Source/WebInspectorUI/Versions/Inspector-iOS-15.0.json:
* Source/WebInspectorUI/Versions/Inspector-iOS-15.4.json:
* Source/WebInspectorUI/Versions/Inspector-iOS-16.0.json:
* Source/WebInspectorUI/Versions/Inspector-iOS-16.4.json:
* Source/WebInspectorUI/Versions/Inspector-iOS-17.0.json:
* Source/WebInspectorUI/Versions/Inspector-iOS-17.2.json:
* Source/WebInspectorUI/Versions/Inspector-iOS-17.4.json:
* Source/WebInspectorUI/Versions/Inspector-iOS-18.0.json:
* Source/WebInspectorUI/Versions/Inspector-iOS-18.2.json:
* Source/WebInspectorUI/Versions/Inspector-macOS-12.0.json:
* Source/WebInspectorUI/Versions/Inspector-macOS-12.3.json:
* Source/WebInspectorUI/Versions/Inspector-macOS-13.0.json:
* Source/WebInspectorUI/Versions/Inspector-macOS-13.3.json:
* Source/WebInspectorUI/Versions/Inspector-macOS-14.0.json:
* Source/WebInspectorUI/Versions/Inspector-macOS-14.2.json:
* Source/WebInspectorUI/Versions/Inspector-macOS-14.4.json:
* Source/WebInspectorUI/Versions/Inspector-macOS-15.0.json:
* Source/WebInspectorUI/Versions/Inspector-macOS-15.2.json:

Canonical link: https://commits.webkit.org/289854@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications

More information about the webkit-changes mailing list