[webkit-changes] [WebKit/WebKit] 9644e7: AX: move definition of Mac NSAccessibility constan...

[Dominic Mazzoni]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9644e79bbfa138919d2400404e59c2491222d452
      https://github.com/WebKit/WebKit/commit/9644e79bbfa138919d2400404e59c2491222d452
  Author: Dominic Mazzoni <dm_mazzoni at apple.com>
  Date:   2025-02-04 (Tue, 04 Feb 2025)

  Changed paths:
    M Source/WebCore/PlatformMac.cmake
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/accessibility/mac/AXObjectCacheMac.mm
    A Source/WebCore/accessibility/mac/CocoaAccessibilityConstants.h
    M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.h
    M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.h
    M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm

  Log Message:
  -----------
  AX: move definition of Mac NSAccessibility constants to a common header file, remove guards
https://bugs.webkit.org/show_bug.cgi?id=286928
rdar://problem/144089453

Reviewed by Chris Fleizach.

To make it easier to identify and audit all of the accessibility
constants in WebKit, move the definition of NSAccessibility constants
to a common header file and remove guards.

The guards are misleading because they look like they're preventing us
from redefining a constant defined in a system header. But in fact,
most system-defined accessibility constants are symbols, so the
symbol names before being deleted in a previous change.

* Source/WebCore/PlatformMac.cmake:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/accessibility/mac/AXObjectCacheMac.mm:
* Source/WebCore/accessibility/mac/CocoaAccessibilityConstants.h: Added.
* Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.h:
* Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.h:
* Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

Canonical link: https://commits.webkit.org/289842@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications